Last modified: 2011-09-17 19:11:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32734, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30734 - Commons Vector.js loads WikiMiniAtlas over http when visiting https://commons
Commons Vector.js loads WikiMiniAtlas over http when visiting https://commons
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
SSL related (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-03 16:06 UTC by Roan Kattouw
Modified: 2011-09-17 19:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2011-09-03 16:06:38 UTC
Not strictly in the scope of this tracker, I know, but putting this in as a TODO for myself.

On [[commons:MediaWiki:Vector.js]] (and possibly elsewhere), this:

var metaBase = 'http://meta.wikimedia.org';
if ( mw.config.get( 'wgServer' ) == 'https://secure.wikimedia.org' ) {
 var metaBase = 'https://secure.wikimedia.org/wikipedia/meta';
}

needs to be changed to just

var metaBase = '//meta.wikimedia.org';

after we deploy HTTPS to meta.
Comment 1 Krinkle 2011-09-03 16:10:16 UTC
There is a structure like that that is about as common, a little bit better:


var xBase = 'http://x.wikimedia.org';
if ( mw.config.get( 'wgServer' ).indexOf('https://') === 0 ) {
 var xBase = 'https://secure.wikimedia.org/wikipedia/x';
}


Except that this one is subject to the same bug, because wgServer doesn't contain http nor https. Until https is on all wikis, wikis should use protocol-relative where possible and keep these if-statements for wikis that don't yet.
Comment 2 Krinkle 2011-09-17 19:11:21 UTC
Marking invalid as it's not a Wikimedia issue, but my previous post shows a work-around for wiks without https, and for those that do have https, the following can be used:


var xBase = '//x.wikimedia.org';
mw.loader.load( xBase + '/w/index.php? ......' );

The latter has been applied to  http://commons.wikimedia.org/wiki/MediaWiki:Vector.js

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links