Last modified: 2012-11-08 17:50:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32823, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30823 - When user enters confirmation code for second time, we show misleading error message
When user enters confirmation code for second time, we show misleading error ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedback (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-08 21:12 UTC by howief
Modified: 2012-11-08 17:50 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description howief 2011-09-08 21:12:54 UTC
1.  On the English Wikipedia: Submit email for email capture (eg., via AFT --> click on "I am highly knowledgeable about this topic and fill in email field)
2.  Wait for Wikimedia email with confirmation instructions
3.  Click on manual confirmation link (http://en.wikipedia.org/wiki/Special:EmailCapture).  Enter confirmation code.  Should get message stating email address has been confirmed.
4.  Click on manual confirmation link again.  Enter confirmation code again.
5.  Should get message stating email address has NOT been confirmed.
6.  User should get message stating "Email address has already been confirmed"
Comment 1 Brion Vibber 2011-09-08 22:37:56 UTC
This seems to be in the EmailCapture extension, which has its own table of addresses and confirmation codes.

Current code attempts to update the row with the matching code to add the verified bit, then claims failure if no rows were changed.

Should probably instead check for presence of a current row, and if it's present and already verified it could then give a different err msg.
Comment 2 Brion Vibber 2011-09-08 22:48:26 UTC
r96627 should fix this -- presumably needs backport for deployment.
Comment 3 howief 2011-09-09 00:27:50 UTC

(In reply to comment #2)
> r96627 should fix this -- presumably needs backport for deployment.

Awesome.  Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links