Last modified: 2011-09-12 20:50:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32841, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30841 - Add unit tests for FormatJson against native PHP json_encode() and json_decode()
Add unit tests for FormatJson against native PHP json_encode() and json_decode()
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-10 06:29 UTC by T. Gries
Modified: 2011-09-12 20:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2011-09-10 06:29:30 UTC
Suggested is to
"... use some tests to make sure that the output from Services_Json and json_{en,de}code are identical."

Enhancement bug filed for an issue in the mailinglist discussion "[Wikitech-l] Re quests about log system":

> - json in php requires a mess of code and potentially a 3rd party
> libraries because:
> -- the bulit-in json json_{en,de}code library functions may not be installed
> -- the bulit-in json library in some cases actually has a bug that makes
> it encode/decode json incorrectly
>
Well, that's why we have the FormatJson wrapper. Could use some tests
to make sure that the output from Services_Json and json_{en,de}code
are identical. I'm whipping up some trivial ones now.

[1] http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/55429
Comment 1 Chad H. 2011-09-10 06:34:35 UTC
I already wrote some initial tests in r96713. Feel free to add more if you'd like :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links