Last modified: 2011-09-12 19:26:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32865, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30865 - div#bodyContent closes too early in missing categories
div#bodyContent closes too early in missing categories
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-12 08:11 UTC by Michael M.
Modified: 2011-09-12 19:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2011-09-12 08:11:45 UTC
The issue doesn't occur in 1.17 so look at a missing category in a wiki with a newer version of MW, like http://translatewiki.net/wiki/Category:Users_in_London

The structure of the HTML is

<div id="bodyContent">
 <div class="noarticletext">
 </div>
</div>
<div id="mw-pages">
</div>

But it should be (like it is in 1.17, in edit mode and for existing categories)

<div id="bodyContent">
 <div class="noarticletext">
 </div>
 <div id="mw-pages">
 </div>
</div>

In Vector this causes a font size that is too big (#bodyContent scales down to 80% which don't apply to the page list). Also gadgets that look for the content in #bodyContent break.
Comment 1 Bawolff (Brian Wolff) 2011-09-12 18:05:34 UTC
Looks as if this might be caused by r91518. Adding a note to that revision.
Comment 2 Brion Vibber 2011-09-12 18:27:34 UTC
Yep, looks like. It's trying to close out a <div class="mw-content-ltr">... which has not been opened in this case.
Comment 3 Brion Vibber 2011-09-12 18:46:44 UTC
Correct behavior is probably to open a sub-div instead of to "close the previous div, show the headings in user language, then open a new div with the page content language again"
Comment 4 Brion Vibber 2011-09-12 19:10:18 UTC
r96886 clears this up for me; please double-check for funky edge cases though!
Comment 5 Brion Vibber 2011-09-12 19:26:28 UTC
Merged as r96888 on 1.18.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links