Last modified: 2011-09-14 23:03:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32885, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30885 - Make AFT fully compatible with MW 1.17
Make AFT fully compatible with MW 1.17
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedback (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Thread:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-13 18:06 UTC by Helder
Modified: 2011-09-14 23:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-09-13 18:06:06 UTC
(Copying on bugzilla so that it doesn't get lost...)

It was reported on the extension's talk page that it doesn't works as expected with MW 1.17:
* [[mw:Thread:Extension talk:ArticleFeedback/Does it work with MW 1.17?]]
* [[mw:Thread:Extension talk:ArticleFeedback/api.php missing]]
Comment 1 Sam Reed (reedy) 2011-09-13 18:08:21 UTC
What's the api.php missing? The api has been there for quite a while
Comment 2 Krinkle 2011-09-13 23:16:07 UTC
ArticleFeedback is an experimental feature created by the Wikimedia Foundation as part of the [[mw: New Editor Engagement]] program. It's still up to undergo some more changes, based on the feedback and the results of it.

It is not a priority to make a previous version of a concept that is still under development compatible with 1.17. Once AFT is ready (ie. 1.0), we could decide to backport it to whatever is the latest release version at that moment if it does not work with that version already. But requesting 1.17 compatibility at this time sounds like a bad idea.

Marking WONTFIX.
Comment 3 MZMcBride 2011-09-13 23:19:29 UTC
(In reply to comment #2)
> ArticleFeedback is an experimental feature created by the Wikimedia Foundation
> as part of the [[mw: New Editor Engagement]] program. It's still up to undergo
> some more changes, based on the feedback and the results of it.

The code should be adaptable to other MediaWiki installations, just like nearly any other MediaWiki extension.

> It is not a priority to make a previous version of a concept that is still
> under development compatible with 1.17. Once AFT is ready (ie. 1.0), we could
> decide to backport it to whatever is the latest release version at that moment
> if it does not work with that version already. But requesting 1.17
> compatibility at this time sounds like a bad idea.

I don't see how priorities are relevant here. It may not be a priority to Wikimedia or to you, but that doesn't make the bug invalid. There are branches for a reason. Having a branched version of the extension that works with _the current version of MediaWiki_ doesn't seem like an unreasonable request.

> Marking WONTFIX.

Re-opening, per the above.
Comment 4 Krinkle 2011-09-13 23:26:28 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > ArticleFeedback is an experimental feature created by the Wikimedia Foundation
> > as part of the [[mw: New Editor Engagement]] program. It's still up to undergo
> > some more changes, based on the feedback and the results of it.
> 
> The code should be adaptable to other MediaWiki installations, just like nearly
> any other MediaWiki extension.

It is. It doesn't contain anything Wikimedia specific as far as I know.

> There are branches
> for a reason. Having a branched version of the extension that works with _the
> current version of MediaWiki_ doesn't seem like an unreasonable request.

Indeed. If it was developed in trunk/extensions to work against trunk/phase3, to be deployed when that mediawiki version is reviewed and released. then it would make sense.

However it was developed in trunk to work on 1.17wmf1 which is a little further ahead. The branched code for ArticleFeedback in REL1_18 should work with 1.18. The code in trunk should work in trunk MediaWiki 1.19. However the code that was branched into 1.17 was never intended to work in 1.17.

If the problems a minor, someone interested could fix the problems in the 1_17 branch. But if it's broken beyond simple patches, we might as well remove it from REL1_17, which makes this bug redundant.
Comment 5 Roan Kattouw 2011-09-14 10:25:43 UTC
Since ArticleFeedback should work with 1.18 and 1.18 will be released soon, I don't think this is worth the effort.
Comment 6 Brion Vibber 2011-09-14 23:03:05 UTC
The ArticleFeedback directory in REL1_17's extensions was a very very old snapshot and far from complete.

Since it's not been developed or maintained for 1.17 (it's been developed for 1.17wmf1 which includes a number of customizations and fixes from 1.18 development), and an apparently working snapshot is available with 1.18, and 1.18's hitting production and release later this month, I wouldn't expect it to be worth the trouble to go fiddling with a 1.17-compatible version.

If you would like to do so, please feel free to do it yourself, but don't expect it to be done for you by the ArticleFeedback maintainers or anybody else; for this reason please don't reopen the bug unless you're taking on the responsibility to actually fulfill it.


Note also that ArticleFeedback is not standalone; it requires the ClickTracking and SimpleSurvey extensions.
Comment 7 Brion Vibber 2011-09-14 23:03:44 UTC
Missed this from my last comment -- I removed the old snapshot from REL1_17/extensions in r97112 so it's not sitting there and confusing people.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links