Last modified: 2011-09-15 23:17:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32920, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30920 - DumpHTML incompatibility with Collection (sidebar issue for SkinOffline)
DumpHTML incompatibility with Collection (sidebar issue for SkinOffline)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DumpHTML (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-15 23:16 UTC by Brion Vibber
Modified: 2011-09-15 23:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-09-15 23:16:02 UTC
The Collection extension adds a portlet to the sidebar array as an HTML chunk like this:

string(534) "<ul id="collectionPortletList"><li id="coll-create_a_book"><a href="../../../../articles/b/o/o/Special%7EBook_a20f.html" title="Create a book or page collection" rel="nofollow">Create a book</a></li><li id="coll-download-as-rl"><a href="../../../../articles/b/o/o/Special%7EBook_a20f.html" title="Download a PDF version of this wiki page" rel="nofollow">Download as PDF</a></li><li id="t-print"><a href="../../../../articles/p/a/g/Page_one.html" title="Printable version of this page [p]" accesskey="p">Printable version</a></li></ul>"

This causes dumpHTML to spew a butt-ton of these while running in SkinOffline::buildSidebar:

PHP Warning:  Invalid argument supplied for foreach() in /var/www/trunk/extensions/DumpHTML/SkinOffline.php on line 36
PHP Stack trace:
PHP   1. {main}() /var/www/trunk/extensions/DumpHTML/dumpHTML.php:0
PHP   2. DumpHTML->doEverything() /var/www/trunk/extensions/DumpHTML/dumpHTML.php:152
PHP   3. DumpHTML->doArticles() /var/www/trunk/extensions/DumpHTML/dumpHTML.inc:148
PHP   4. DumpHTML->doArticle() /var/www/trunk/extensions/DumpHTML/dumpHTML.inc:209
PHP   5. DumpHTML->getArticleHTML() /var/www/trunk/extensions/DumpHTML/dumpHTML.inc:479
PHP   6. SkinTemplate->outputPage() /var/www/trunk/extensions/DumpHTML/dumpHTML.inc:814
PHP   7. SkinOffline->buildSidebar() /var/www/trunk/includes/SkinTemplate.php:470

Probably should just ignore such sections; you at least wouldn't be able to use Collection on a static output. :)
Comment 1 Brion Vibber 2011-09-15 23:17:32 UTC
r97219 drops these sections while processing for DumpHTML in SkinOffline.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links