Last modified: 2014-06-04 19:49:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32959, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30959 - Give editintro an own css id/class
Give editintro an own css id/class
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-18 01:08 UTC by Subfader
Modified: 2014-06-04 19:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Subfader 2011-09-18 01:08:37 UTC
When I create pages using editintro=Template:Foo I'd like too the included content of Template:Foo in a div with an own css class or id to give it some background etc. which is even more useful when you start with preview=yes.
Comment 1 Subfader 2011-09-18 01:30:50 UTC
** I'd like to see the included content...

Best would be if the content was passed to [[MediaWiki:Editintro]] for full customization options.
Comment 2 Bawolff (Brian Wolff) 2014-02-19 12:38:26 UTC
To clarify bug report:
When you use the editintro url parameter to add some template to the top of the edit page (for example: https://en.wikipedia.org/wiki/Project:Sandbox?editintro=:Main_Page&action=edit . People often do this to have custom help text), the included template should be contained within a <div> tag, which has some class (say mw-editintro). So you would have <div class="mw-editintro">TEMPLATE HERE</div> instead of current system where template is just plopped in without a containing <div> tag.

See also EditPage::showCustomIntro in includes/EditPage.php for where its implemented.

>Best would be if the content was passed to [[MediaWiki:Editintro]] for full
>customization options.

That seems overkill. Lets stick with the css class, unless you have a compelling use case for using the message.
Comment 3 andnlnbn18 2014-02-19 14:04:48 UTC
can i work on it??
Comment 5 andnlnbn18 2014-02-25 12:25:51 UTC
manipulating the showCustomIntro on page  2111 in /includes/EditPage.php https://doc.wikimedia.org/mediawiki-core/master/php/html/EditPage_8php_source.html as  http://pastebin.com/1v6XtYAw works??
Comment 6 Andre Klapper 2014-02-25 13:53:37 UTC
It is up to you to test and check your patch to see if it works. 
I cannot judge the code that you pasted on pastebin.com as it is not in patch format and it is cumbersome to compare line for line manually. Please always provide changes in patch format. You find pointers in the link in comment 4.
Comment 7 Bawolff (Brian Wolff) 2014-02-25 14:40:55 UTC
There is actually a fairly obvious syntax error in the linked pastebin.... but yes, please try it on your own mediawiki and see for yourself if it appears to work correctly.
Comment 8 Gerrit Notification Bot 2014-02-26 15:37:52 UTC
Change 115607 had a related patch set uploaded by Lekshmi:
editintro given a css class of its own

https://gerrit.wikimedia.org/r/115607
Comment 9 Bawolff (Brian Wolff) 2014-06-04 19:46:47 UTC
Note, that editnotices are not included.

Will appear on wikipedia on about June 12th
Comment 10 Gerrit Notification Bot 2014-06-04 19:49:21 UTC
Change 115607 merged by jenkins-bot:
editintro given a css class of its own

https://gerrit.wikimedia.org/r/115607

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links