Last modified: 2011-09-19 12:11:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32969, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30969 - Interwiki links messing up results
Interwiki links messing up results
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-18 14:06 UTC by Jeroen De Dauw
Modified: 2011-09-19 12:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of table format with several pages having incorrect links (15.36 KB, image/png)
2011-09-18 14:08 UTC, Jeroen De Dauw
Details

Description Jeroen De Dauw 2011-09-18 14:06:10 UTC
I'm getting the values of some SMW_SQL2_ constants in my wiki pages as interwiki links, making page "Foobar" link to "Smw-redi:Foobar", and sometimes making an otherwise empty result ":smw-border:" show up. I'm guessing the SQL store should be taking these out, but is failing to do so for some reason.

This blocks the 1.6.2 release.
Comment 1 Jeroen De Dauw 2011-09-18 14:08:19 UTC
Created attachment 9069 [details]
Screenshot of table format with several pages having incorrect links
Comment 2 Jeroen De Dauw 2011-09-18 14:13:56 UTC
MediaWiki 	1.19alpha (r97415)
PHP 	5.3.5-1ubuntu7.2 (apache2handler)
MySQL 	5.1.54-1ubuntu4
SMW trunk
Comment 3 Jeroen De Dauw 2011-09-19 10:23:33 UTC
Ok, I figured out why this was happening on one of my wikis, and not the other. The query in which I'm having the issue is

{{#ask:[[:+]]|?Modification date|format=table}}

while 

{{#ask:[[Modification date::+]]|?Modification date|format=table}}

works fine.

Doing a full refresh of all data (I deleted my tables and did a reinstall) does not fix this, so it's not some data already messed up on my wiki.

Removing this as blocker; it was already in the previous releases.
Comment 4 Markus Krötzsch 2011-09-19 11:48:42 UTC
Fixed in SVN now. The fix employs a post-query filtering to avoid such values to show up. The alternative would be to filter in the SQL query already, but this would add additional conditions to all queries. In most cases, this should not be needed since internal auxiliary entries should normally not have the data stored that would make them potential query results in any case. Mostly very general queries like namespace filtering could cause the issue, I think.

The post-query filtering has the one disadvantage that it leads to fewer results than expected in the affected cases. "Further results" will still work properly, but the actual list of results shown may not contain limit many entries if some are filtered. Since it seems to be a rare situation, I would prefer this over the performance-degrading approach of filtering this in SQL.
Comment 5 Markus Krötzsch 2011-09-19 12:11:38 UTC
P.S.: The fix is in r97463.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links