Last modified: 2011-09-28 18:16:24 UTC
While testing on test2.wikipedia.org I noticed a few issues that need taking care of:
Created attachment 9078 [details] directionality of "hide/show" of toc.
Created attachment 9079 [details] positioning of FlaggedRevs element is always top right
Created attachment 9080 [details] Image positioned at the left but using margins for right aligned element
happened both as anon and logged in.
The TOC works for me on test2.
* TOC works for me as well * The FlaggedRevs position is intended behavior: nothing in the page content area should depend on the user language direction. It is rather the infobox which uses CSS from MediaWiki:Common.css which is flipped (most wikis will need to add @noflip where necessary in their on-wiki CSS). * Same for the image, it should be at the right side. I'm figuring out why it isn't (I hope it's also due to the on-wiki CSS).
Ah no, the image is indeed at the left side (..|thumb|left|..), so the margin is changed due to local CSS as well.
the toc is due to the <h2> being rtl. that flips the bidi logic on OS X I think. If I make that text latin script, it seems to be working.
The TOC title issue is fixed with r97622. (Needs merging & software update.) This bug could be closed, but we might leave it open because I assume more BiDi bugs will pop up :)
FYI, fixed the CSS for the infobox & image: http://test2.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&action=historysubmit&diff=34980&oldid=34681
I don't quite understand why should this be customized on-wiki and not fixed in the source. I added this to div.flaggedrevs_short at FlaggedRevs/presentation/modules/flaggedrevs.css : position: absolute; right: 0em; top: -4em; This fixed the problem nicely for LTR and RTL. It's a workaround, it's a bit ugly, it may have to be improved a little more, but it's better than customizing Common.css.
There's no problem with the FlaggedRevs box, it aligns correctly according to the page content direction. The problem was with the infobox using local CSS float:right; which is flipped to float:left; causing the infobox to display at the left side, which is wrong. I added @noflip so the infobox CSS is not flipped. (Same for the image).
Prepared for en.wp as well: https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special%3AComparePages&page1=MediaWiki%3ACommon.css&page2=MediaWiki%3ACommon.css%2Fsandbox&rev1=&rev2=
Awesome. You can make the changes already on MediaWiki:Common.css, it won't break anything.
Also something that should be tested... All the skins... http://test2.wikipedia.org/wiki/Islam?uselang=he&useskin=standard
Per IRC, r96760 will be merged (it was a follow-up to a rev that was already merged).
Created attachment 9081 [details] Screenshot of skin=standard breakage in mixed ltr/rtl mode
Yeah, this has been broken since it exists, see http://he.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99?useskin=standard&uselang=he Fixed it anyway in r97657.
What is still needed here?
Assigned to Robin. Please give it back if you think it shouldn't be :).
All issues reported here were fixed or followed up. It could be re-opened when new RTL/BiDi regressions appear.
