Last modified: 2012-02-23 02:10:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33081, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31081 - $wgEnotifUseJobQ shouldn't unconditionally unqueue jobs
$wgEnotifUseJobQ shouldn't unconditionally unqueue jobs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.17.x
All All
: Unprioritized normal (vote)
: 1.19.0 release
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-21 23:32 UTC by Tim Starling
Modified: 2012-02-23 02:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2011-09-21 23:32:17 UTC 
With $wgEnotifUseJobQ enabled, a job is queued unconditionally, regardless of whether any emails will be sent. The relevant logic for deciding who to send emails to is implemented in actuallyNotifyOnPageChange(), which is common to job execution and non-job email sending.

This is especially obvious with $wgEnotifWatchlist=false and $wgEnotifUserTalk=true, as it is on enwiki. The page title is not checked to see if it is a user talk page before the job is queued, so more than 90% of queued jobs are no-ops.
Comment 1 Sam Reed (reedy) 2011-09-22 12:15:04 UTC 
r97810
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links