Last modified: 2012-04-19 21:22:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33088, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31088 - [Regression] "Create account/log in" should use the current title and query in returnto
[Regression] "Create account/log in" should use the current title and query i...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: Highest major (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-22 06:40 UTC by Krinkle
Modified: 2012-04-19 21:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-09-22 06:40:10 UTC
Just noticed this since MW.org is running 1.18wmf1.

When going to a link like: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#code-comments

Logging in will go back to the main "Special:Code", not to "MediaWiki/94951".
Comment 1 Sam Reed (reedy) 2011-09-22 10:32:26 UTC
(In reply to comment #0)
> Just noticed this since MW.org is running 1.18wmf1.
> 
> When going to a link like:
> http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#code-comments
> 
> Logging in will go back to the main "Special:Code", not to "MediaWiki/94951".

Now, is that definitely a CR regression, or may it actually be MW itself?
Comment 2 Brion Vibber 2011-09-22 22:26:58 UTC
This is core; you can see it with Special:Version/foo as well.

Looks like it may be related to the context stuff; $this->thispage on SkinTemplate (now retrieved via $this->getTitle() as a context goodie) turns up with the short name (paramter removed), so it doesn't get passed on when we build the returnto link.
Comment 3 Brion Vibber 2011-09-22 22:33:55 UTC
Can't repro on r85252 (just after it was switched from $this->mTitle to $this->getTitle), so the title object is getting corrupted somewhere else in the stack.
Comment 4 Aaron Schulz 2011-09-27 18:21:47 UTC
(In reply to comment #3)
> Can't repro on r85252 (just after it was switched from $this->mTitle to
> $this->getTitle), so the title object is getting corrupted somewhere else in
> the stack.

Is that the right rev #?
Comment 5 Aaron Schulz 2011-09-27 18:56:31 UTC
Fixed in r98235.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links