Last modified: 2011-09-22 22:16:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33089, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31089 - MediaWiki:Ipbreason-dropdown parsing is broken in 1.18wmf1
MediaWiki:Ipbreason-dropdown parsing is broken in 1.18wmf1
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.18.x
All All
: Highest major (vote)
: ---
Assigned To: Brion Vibber
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-22 10:33 UTC by Max Semenik
Modified: 2011-09-22 22:16 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Max Semenik 2011-09-22 10:33:30 UTC 
http://www.mediawiki.org/wiki/MediaWiki:Ipbreason-dropdown gets parsed wrong, cf http://www.mediawiki.org/wiki/Special:Block/Jimbo_Wales

Block reasons containing piped links are shown partially
Comment 1 Brion Vibber 2011-09-22 21:57:35 UTC 
r83795 appears to have last rewritten Special:Block ...

That switched it from generating the list with Xml::listDropDown() to going through HTMLForm's 'selectandother' type (HTMLSelectAndOtherField class).

Most of that code seems to come from r83298... it just doesn't look compatible, as it adds a "|" explosion and seems to use it for ..... some kind of special naming keys or something?
Comment 2 Brion Vibber 2011-09-22 22:13:15 UTC 
r97860 fixes regression by removing the extra "|" syntax feature that HTMLSelectAndOtherField added that was incompatible with Xml::listDropDown.

Block reasons from mediawiki.org containing links now work again.
Comment 3 Brion Vibber 2011-09-22 22:16:42 UTC 
Merged to REL1_18 and 1.18wmf1 in r97861, r97862.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links