Last modified: 2011-09-22 23:40:46 UTC
This problem affects wikiEditor for MW 1.17 - I have not tried other versions. In jQuery.wikiEditor.toolbar.js, the buildTool function improperly uses a for..in loop to iterate through an array (specifically, for applying filters). This works fine as long as nobody has added to the Array.prototype, but if they have the for..in loop will pick up non-integer keys. Although some JavaScript libraries shy away from making changes to prototypes, there are plenty of legacy ones which still do. This bug causes blocking JavaScript errors whenever an addition to Array.prototype has a value which causes jQuery to return a wrapped array instead of an actual jQuery collection.
I just checked out SVN HEAD for this, someone has already fixed it. Shall I make a patch specifically for 1.17?
It is also fixed in REL_18, so it appears that just 1.17 is affected.
Resolving as dupe of bug 29106 -- as noted above, this was already fixed on trunk & REL1_18. *** This bug has been marked as a duplicate of bug 29106 ***