Last modified: 2011-09-23 15:16:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33116, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31116 - CategorySuggest Multiple Fixes and 1.16 support
CategorySuggest Multiple Fixes and 1.16 support
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Unprioritized critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-23 11:45 UTC by petter.tornberg
Modified: 2011-09-23 15:16 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A fixed version of CategorySuggest. See description. (50.00 KB, application/x-tar)
2011-09-23 11:45 UTC, petter.tornberg
Details

Description petter.tornberg 2011-09-23 11:45:47 UTC
Created attachment 9092 [details]
A fixed version of CategorySuggest. See description.

The attached file fixes some basic issues to make CategorySuggest work in 1.16. 

Some of the hooks took references instead of variables, making it crash.

I've also rewritten the database query, "optimizing" it (now uses category table instead of categorylink table, lot less rows and no DISTINCT necessary) and fixing bugs (it now converts category names to utf8 string before running UPPER, this would previously break 1.16 since cat_title is varbinary, which UPPER of course can't handle).

This is my first contribution, so do expect errors! And sorry if "critical" is an incorrect classification.
Comment 1 petter.tornberg 2011-09-23 11:58:40 UTC
It should be mentioned that the database query fix probably breaks compatibility with 1.11, since the category table wasn't added until 1.13. I guess it would be easy to check the version before choosing which query to use though.
Comment 2 Sam Reed (reedy) 2011-09-23 15:16:52 UTC
That's not our maintained SVN, so you will have more luck with this contacting the maintainer via http://sourceforge.net/projects/mediawiki/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links