Last modified: 2014-08-29 01:58:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31219 - MonoBook: Footer is malformed
MonoBook: Footer is malformed
Status: NEW
Product: MediaWiki skins
Classification: Unclassified
MonoBook (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-28 18:51 UTC by Derk-Jan Hartman
Modified: 2014-08-29 01:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
1.17 (53.65 KB, image/png)
2011-09-28 18:51 UTC, Derk-Jan Hartman
Details
1.18 (44.42 KB, image/png)
2011-09-28 18:51 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2011-09-28 18:51:26 UTC
Created attachment 9112 [details]
1.17

Please note the change in layout between 1.17 and 1.18 of the monobook footer. screenshots attached.
Comment 1 Derk-Jan Hartman 2011-09-28 18:51:50 UTC
Created attachment 9113 [details]
1.18
Comment 2 Daniel Friesen 2011-09-28 23:18:36 UTC
Hmmm... wmf may not have been using footerlinks and may have instead been using a custom skin hack that got un-done when upgraded.

- The contact us should be added in with the SkinTemplateOutputPageBeforeExec hook by modifying $tpl->data['footerlinks'][???].
- Wikimedia also seams to display: block; the copyright and if visible lastmod line, the monobook css should be tweaked in some wmf specific place (typically the proper place for this would be a wiki's site-css but in wmf's case this applies to all wmf wikis but no default-mw wikis so some wmf common stylesheet is the proper thing here).
Comment 3 Derk-Jan Hartman 2011-09-29 16:43:30 UTC
Actually, this is not a regression. It seems that the English Wikipedia have made local overrides to pretty this up a bit, by adding <br> statements. 

http://tr.wikipedia.org/wiki/Farrah_Fawcett?useskin=monobook on 1.17wmf1 behaves the same as the dutch 1.18 it seems.


So not a regression, but still ugly, and something that we should probably improve.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links