Last modified: 2011-11-17 21:49:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33253, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31253 - update prefillLocation to use 1.18's improved EXIF handling for location / GPS data
update prefillLocation to use 1.18's improved EXIF handling for location / GP...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Extensi...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-29 17:53 UTC by Ben Hartshorne
Modified: 2011-11-17 21:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ben Hartshorne 2011-09-29 17:53:15 UTC
The UploadWizard currently has a noop for prefillLocation with comments claiming that mediawiki's exif parsing is broken for GPS data. Exif handling in 1.18 is greatly improved; if the problems with location data handling have been fixed (and my naive inspection leads me to believe that they have), update UploadWizard to use this improved parsing to pull out location data and automatically identify the location in uploaded images.
Comment 1 Ben Hartshorne 2011-09-29 20:44:05 UTC
Though I'm sure it will be easy to create .jpgs with gps data embedded, if you want a test image download the full rez copy of http://en.wikipedia.org/wiki/File:Northbrae_Tunnel.jpg.  It has its location in the EXIF tags.

For verification, the exif tags themselves read:
GPSLatitudeRef: N
GPSLatitude: 37/1 5344/100 0/1
GPSLongitudeRef: W
GPSRongitude: 122/1 1642/100 0/1

When presented for human consumption, they should read:
37.8906°N, 122.2736°W
Comment 2 Bawolff (Brian Wolff) 2011-09-30 03:23:06 UTC
>if the problems with location data handling have been fixed...

For reference, yes it has been fixed.

Note, in MediaWiki 1.18, we (internally) convert GPS data into a single decimal value (So if the latitude was 50° 57′ 49.8″ N, we'd store GPSLatitude = 50.9638339701 instead of exif's weird array thingy and seperate prop for direction)
Comment 3 Brion Vibber 2011-10-04 00:05:15 UTC
That test image returns nice handy entries in the metadata dictionary during test upload on trunk:

gpslatitude 37.890666666667	
gpslongitude -122.27366666667

However, the prefillLocation function doesn't mention where the data's supposed to get placed, and there don't appear to be any location fields sitting about to just plop them into.

Is it necessary to also devise location fields, some sort of output format, etc?
Comment 4 Neil Kandalgaonkar 2011-10-04 00:40:43 UTC
I wrote a spec for this back in January, when we were trying to hire Jeroen. We ended up not hiring him for this contract, for reasons which remain shrouded in bureaucracy.

http://www.mediawiki.org/wiki/Extension:UploadWizard/Location

Despite the length of the spec, I don't think it's a lot of time to develop this -- it's just describing pretty standard features that slippy-map APIs have, and how to display them.
Comment 5 Brion Vibber 2011-10-04 00:43:57 UTC
Spiff, added that link to bug metadata.
Comment 6 Neil Kandalgaonkar 2011-11-17 21:49:38 UTC
Fixed, although it breaks if the altitude was included. See #32410, #32408

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links