Last modified: 2011-10-03 22:45:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33282, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31282 - InstantCommons tif thumbnails should work without $wgTiffThumbnailType set on local wiki
InstantCommons tif thumbnails should work without $wgTiffThumbnailType set on...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-30 18:01 UTC by Aude
Modified: 2011-10-03 22:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2011-09-30 18:01:54 UTC
.tif thumbnails from a foreign repo (Wikimedia Commons) don't work on a local wiki, unless $wgTiffThumbnailType is specified in LocalSettings.php:

$wgTiffThumbnailType = array( 'jpg', 'image/jpeg' );

These thumbnails should just work, regardless if $wgTiffThumbnailType is set on the local wiki.
Comment 1 Brion Vibber 2011-10-03 21:50:36 UTC
Confirmed on trunk -- icky!
Comment 2 Brion Vibber 2011-10-03 22:05:56 UTC
Fixed in r98812, marking for 1.18 etc.

This feels a bit hacky -- TiffHandler::canRender() right now checks the local tiff thumbnailing settings to decide if we can render thumbs or not, but for files loaded over ForeignAPIRepo we generally are using premade thumbnails from somewhere else and it doesn't matter if we could create them locally.

May wish to do further refactorings on the file, file repo, and media handler APIs to better distinguish between things that need to be done locally and things that don't.
Comment 3 Brion Vibber 2011-10-03 22:45:52 UTC
Note that there are other things like multipage support that are also broken in this configuration...

Starting to collect some notes for further work at [[mw:Requests for comment/Refactor on File-FileRepo-MediaHandler]].

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links