Last modified: 2011-10-02 00:55:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33301, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31301 - Fix broken cache for http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/client/flaggedrevs.js?87&301-3
Fix broken cache for http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized critical (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-01 23:56 UTC by Saibo
Modified: 2011-10-02 00:55 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
http headers and html content of error (308.18 KB, image/png)
2011-10-02 00:10 UTC, Krinkle
Details
http headers and html content of working url (different query string) (265.91 KB, image/png)
2011-10-02 00:15 UTC, Krinkle
Details
http headers and html content of working url (different query string) - cache hit (276.25 KB, image/png)
2011-10-02 00:20 UTC, Krinkle
Details

Description Saibo 2011-10-01 23:56:21 UTC
I (and other users in dewp http://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Diff_und_Artikelansicht ) get the JS error "Uncaught exception: ReferenceError: Undefined variable: FlaggedRevs" (Opera, not logged in) and similar errors in Firefox (logged in) when viewing(!) an random article http://de.wikipedia.org/wiki/Spezial:Zuf%C3%A4llige_Seite  This at least prevents the article text to be loaded in diff view (which is urgently needed for re-sighting) - example: http://de.wikipedia.org/w/index.php?title=Hinschenfelde&diff=80985219&oldid=80975076 . It started not to work approx. at 17:01, 30. Sep. 2011 (UTC)

BTW: Don't the tests or pre-deployment tests include a simple article view and look in the JS error console? ;)
Comment 1 Krinkle 2011-10-02 00:00:03 UTC
The error you are referring to (Uncaught ReferenceError: FlaggedRevs is not defined) is not relevant to this problem. Looking further into my error console I see a bigger fish just above that one:

Failed to load resource: the server responded with a status of 404 (Not Found)
http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/client/flaggedrevs.js?87&301-3

There is an issue with Wikimedia's -1-17/1-18 set up.

This was tested pre-deployment and worked fine however that was on 1.18.
Comment 2 Krinkle 2011-10-02 00:02:46 UTC
Hm.. changing the 87&301-3 in the url fixes it.

http://bits.wikimedia.org/w/extensions-1.17/FlaggedRevs/client/flaggedrevs.js?foo

Cache pollution ?
Comment 3 Aaron Schulz 2011-10-02 00:06:29 UTC
AFAIK nothing FlaggedRevs was deployed on dewiki and it is still running MediaWiki 1.17. I'm not sure why this would break.

Actually, in 1.18, this fragile (due to load order) mix of inline and non-inline JS will be gone.
Comment 4 Krinkle 2011-10-02 00:09:12 UTC
Seems to only affect european users, or otherwise a selection of users.
Comment 5 Krinkle 2011-10-02 00:10:47 UTC
Created attachment 9138 [details]
http headers and html content of error
Comment 6 Krinkle 2011-10-02 00:11:08 UTC
Note that it's showing a Wikimedia-wiki style error, which are not enabled on bits today
Comment 7 Krinkle 2011-10-02 00:15:21 UTC
Created attachment 9139 [details]
http headers and html content of working url (different query string)
Comment 8 Krinkle 2011-10-02 00:20:00 UTC
Created attachment 9140 [details]
http headers and html content of working url (different query string) - cache hit
Comment 9 Krinkle 2011-10-02 00:40:02 UTC
Robla suggest not to nuke the cache of this one just yet to allow investigation to cause.

I suggest we bump wgStyleVersion instead so that atleast de.wp is able to review revisions again!
Comment 10 Aaron Schulz 2011-10-02 00:42:30 UTC
(In reply to comment #9)
> Robla suggest not to nuke the cache of this one just yet to allow investigation
> to cause.
> 
> I suggest we bump wgStyleVersion instead so that atleast de.wp is able to
> review revisions again!

That actually works for you?
Comment 11 Aaron Schulz 2011-10-02 00:45:23 UTC
I'll bump the version per comment #2.
Comment 12 Krinkle 2011-10-02 00:54:45 UTC
Fixed. Visiting the original url [0] loads the correct version now;

[0] http://de.wikipedia.org/w/index.php?title=Hinschenfelde&diff=80985219&oldid=80975076

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links