Last modified: 2011-10-04 22:42:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33356, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31356 - [MirrorTools] Some api functions are not public
[MirrorTools] Some api functions are not public
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-04 21:36 UTC by Samuel Lampa
Modified: 2011-10-04 22:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Changes from "protected" to "public" for a few API functions. (1.08 KB, patch)
2011-10-04 21:36 UTC, Samuel Lampa
Details

Description Samuel Lampa 2011-10-04 21:36:55 UTC
Created attachment 9157 [details]
Changes from "protected" to "public" for a few API functions.

I get a message like this, but the same for for a number of functions (listed below):

Fatal error: Access level to ApiMirrorEditPage::getDescription() must be public (as in class ApiEditPage) in /home/samuel/www/smw-trunk/extensions/MirrorTools/APIMirrorTools.php on line 33
Call Stack
#	Time	Memory	Function	Location
1	0.0014	398300	{main}( )	../api.php:0
2	0.1687	9933908	ApiMain->execute( )	../api.php:117
3	0.1687	9933952	ApiMain->executeActionWithErrorHandling( )	../ApiMain.php:342
4	0.1743	10239180	ApiMain->substituteResultWithError( )	../ApiMain.php:369
5	0.1744	10239544	ApiMain->makeHelpMsg( )	../ApiMain.php:510
6	0.1827	10880468	ApiMain->reallyMakeHelpMsg( )	../ApiMain.php:893
7	0.1875	11048656	AutoLoader::autoload( )	../ApiMain.php:0
8	0.1893	11166256	require( '/home/samuel/www/smw-trunk/extensions/MirrorTools/APIMirrorTools.php' )

By changing from "protected" to "public" for the getDescription() function in APIMirrorTools.php, I see that the same error is there also for functions:

getPossibleErrors()
getAllowedParams()
getParamDescription()
getExamples()

The attached patch seems to fix this.
Comment 1 Sam Reed (reedy) 2011-10-04 22:42:53 UTC
r98946

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links