Last modified: 2011-10-07 01:36:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33376, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31376 - Improve the display of [[MediaWiki:revreview-cancel]]
Improve the display of [[MediaWiki:revreview-cancel]]
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-05 13:51 UTC by Leinad
Modified: 2011-10-07 01:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Leinad 2011-10-05 13:51:22 UTC 
When no changes pending on review, there is no sense to display button [[MediaWiki:revreview-cancel]].

For example when I open page http://pl.wikipedia.org/wiki/Strona_g%C5%82%C3%B3wna, the button "Cancel" also contains the same url (http://pl.wikipedia.org/wiki/Strona_g%C5%82%C3%B3wna).
Comment 1 Aaron Schulz 2011-10-05 17:26:11 UTC 
It is possible to use the form to unaccept pages, so a "cancel" button isn't *totally* useless there...though unlikely to be used when the revision is already accepted.

The button should probably only show if the user came from a certain urls, such as via ?cancenReviewTo=x and take the user back there.
Comment 2 Aaron Schulz 2011-10-06 20:11:27 UTC 
The button only shows on diff pages as of r99131.
Comment 3 Aaron Schulz 2011-10-07 01:36:56 UTC 
Removed in r99182.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links