Last modified: 2011-10-11 07:59:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33420, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31420 - tablesorter and rowspans in headers
tablesorter and rowspans in headers
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/wiki/List_of...
:
Depends on:
Blocks: 31601 29068
  Show dependency treegraph
 
Reported: 2011-10-06 09:16 UTC by Derk-Jan Hartman
Modified: 2011-10-11 07:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2011-10-06 09:16:23 UTC
There is an issue with complicated tables, where there are two header rows, with rowspans on some of the header elements. When you try to sort, the tablesorter will 'explode' the rowspans, and it does this not only on tbody elements, but also on thead elements.

Suggest we change $table.find( '[rowspan]' ).each(function() to $table.find( 'tbody [rowspan]' ).each(function()

I'm not sure if that will work, but it might...
Comment 1 Roan Kattouw 2011-10-06 12:23:36 UTC
(In reply to comment #0)
> There is an issue with complicated tables, where there are two header rows,
> with rowspans on some of the header elements. When you try to sort, the
> tablesorter will 'explode' the rowspans, and it does this not only on tbody
> elements, but also on thead elements.
> 
> Suggest we change $table.find( '[rowspan]' ).each(function() to $table.find(
> 'tbody [rowspan]' ).each(function()
> 
> I'm not sure if that will work, but it might...
I'll give that a spin.
Comment 2 Roan Kattouw 2011-10-06 12:54:44 UTC
Fixed in r99092, will deploy shortly. Derk-Jan's suggestion was spot on, thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links