Last modified: 2011-10-28 02:06:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33431, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31431 - Link from recent revisions goes to "no such special page"
Link from recent revisions goes to "no such special page"
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-06 15:05 UTC by Mark A. Hershberger
Modified: 2011-10-28 02:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2011-10-06 15:05:20 UTC
From [[WP:VPT#No_such_special_page]]:

Clicking on a Recent changes entry with the URL http://en.wikipedia.org/w/index.php?title=Sameera_Mallawarachchi&curid=33321830&action=history caused an unexpected response. The link is to an article I had just deleted. Strangely, the link shows a Wikipedia page with a title of Error, an article-like title of No such special page and content of You have requested a special page that is not recognized by Wikipedia. A list of all recognized special pages may be found at Special:Specialpages. If the &curid field is removed, it responds more sensibly showing deletion information.
Comment 1 Daniel Friesen 2011-10-06 16:41:42 UTC
The fact that it's a special page error is a separate bug (we need to implement a real Badtitle special page).

The bug appears to be due to our title handling:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Wiki.php?view=markup#l62

Instead of calling Title::newFromURL the code that handles the &curid= activates when you have a &curid= however because the title was deleted and the page_id no longer exists Title::newFromID returns null and Badtitle is returned.

I think we should change that set of code to work on the "if it's not set model". ie: Instead of elseif, each of those blocks is a `if ( is_null( $ret ) && [...] )` then if any case is active but the Title:: for that case returns null the next case will activate.

In the case of a &curid=###&title= if &curid= exists it will override but if it doesn't &title= will return a title.
Comment 2 Mark A. Hershberger 2011-10-15 20:03:32 UTC
EXAMPLE: http://en.wikipedia.org/w/index.php?curid=1
Comment 4 Mark A. Hershberger 2011-10-15 22:03:38 UTC
tagging bugs for Marcus to look at
Comment 5 Bawolff (Brian Wolff) 2011-10-21 21:00:34 UTC
Another example (namespace with empty page part) - http://en.wikipedia.org/wiki/User:
Comment 6 Daniel Friesen 2011-10-21 21:48:19 UTC
(In reply to comment #5)
> Another example (namespace with empty page part) -
> http://en.wikipedia.org/wiki/User:

That's a little more to do with us not having a proper Badtitle page, than with the other oldid bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links