Last modified: 2011-10-13 21:18:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33489, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31489 - Logged-out users might overwrite earlier unsighted revisions due to oldid in edit link
Logged-out users might overwrite earlier unsighted revisions due to oldid in ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal critical with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 06:46 UTC by Matthias Becker
Modified: 2011-10-13 21:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Becker 2011-10-07 06:46:50 UTC
An IP user of the German Wikipedia reported an issue with not logged-in users. 

If revisions have not been reviewed an IP user's edit might overwrite the earlier made but not yet reviewed edits.

See
http://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&oldid=94478779#MW118:_Bearbeitung_eines_ungesichteten_Artikels

User did not report which OS and browser but another user could reproduce the issue with Opera.
Comment 1 Robin (syrcro) 2011-10-07 11:07:33 UTC
Reproduced with Win 7 Pro SP 1 (German), Chrome 14.
Comment 2 Steef 2011-10-07 18:49:05 UTC
Too clearify it: If you click the edit-Button on the stable version of a page, not the current (unstable) version of the page is edited as prior to 1.18, but instead the stableversion is opened to edit (oldid). This leads to a notice that the user isn't editing the current version, but I think that many users will just ignore the notice, edit the stable version and overwrite unstable changes.

This isn't restricted to logged-out users, it affects everybody who uses the stable version of an article as standard.
Comment 3 Aaron Schulz 2011-10-11 21:33:17 UTC
Possibly caused by r80001. Previously, the edit link did not have oldid=x in it for the stable version like this.
Comment 4 Aaron Schulz 2011-10-11 22:18:01 UTC
Fixed on site, will port to /trunk later.
Comment 5 Aaron Schulz 2011-10-12 01:08:29 UTC
Fixed in r99614.
Comment 6 Bergi 2011-10-12 21:08:21 UTC
I think a edit link should link to a form where you can edit the content you're currently seeing. What if you find an error, want to fix it, and can't find it in the source any more (and going back to view tab it's still there)?
So when we link to another version to edit than the shown, we should point that out, e.g. in the edit links tooltip.
Comment 7 Aaron Schulz 2011-10-13 04:43:37 UTC
(In reply to comment #6)
> I think a edit link should link to a form where you can edit the content you're
> currently seeing.
That's going to cause the same problem this bug reports. This UI change won't happen.

> What if you find an error, want to fix it, and can't find it
> in the source any more (and going back to view tab it's still there)?
That's what the notice in the edit form is for ("pending changes affect the area you are editing").

> So when we link to another version to edit than the shown, we should point that
> out, e.g. in the edit links tooltip.
No one is going to notice that.

The current behavior is back to the long-established UI behavior of the software.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links