Last modified: 2013-09-15 19:45:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33495, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31495 - Missing external link problem on IE6
Missing external link problem on IE6
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.22.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 14:21 UTC by Derk-Jan Hartman
Modified: 2013-09-15 19:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2011-10-07 14:21:40 UTC
Perhaps the PNG 24 issue again ?
Comment 2 Erwin Dokter 2011-10-07 16:31:56 UTC
IE6 would show the icon with a gray background, so that is not the issue. What I do notice is that the 13px padding is also missing in IE6, pointing to a CSS problem.
Comment 3 Brion Vibber 2011-10-07 17:57:45 UTC
Aren't the link icons not shown on IE6 because IE6 never supported them properly?
Comment 4 Brion Vibber 2011-10-07 18:40:44 UTC
Looks like....

Vector has no external link icons or space for them on IE 6 in 1.16, 1.17, or 1.18.

Monobook did have external link icons on IE 6 in 1.16 and 1.17. In 1.18 there's a space but I don't see the icons.
Comment 5 Erwin Dokter 2011-10-07 20:05:29 UTC
Vector's screen.css does contain this code:

div#content a.external,
div#content a[href ^="gopher://"] {
	/* @embed */
	background: url(images/external-link-ltr-icon.png) center right no-repeat;
	padding-right: 13px;
}

'div#content a.external' is by all intent and purpose supported by IE6, and the external link icon used to be visible in Vector in IE6.

I don't have IE with developer toolbar at hand, otherwise I could investigate why the rule is ignored (judging from the fact that the padding is also not applied).
Comment 6 Michael M. 2011-10-08 08:12:33 UTC
There is a report on de.wikipedia that the external link icon is also missing in Monobook with Opera 9.10.521 on Linux i686 2.4.20-8 RedHat.
Comment 7 Erwin Dokter 2011-12-15 13:36:12 UTC
I found the cause: IE6 and 7 ignores any declaration *as a whole* when any of them contains pseudo elements or classes, in this case, a[href ^="gopher://"].

The only solution is to split them in two separate declarations.

div#content a[href ^="gopher://"] {
    /* @embed */
    background: url(images/external-link-ltr-icon.png) center right no-repeat;
    padding-right: 13px;
}
div#content a.external {
    /* @embed */
    background: url(images/external-link-ltr-icon.png) center right no-repeat;
    padding-right: 13px;
}
Comment 8 Daniel Kinzler 2011-12-15 13:55:24 UTC
we have a css rule for gopher? seriously? can we, like, just drop that?
Comment 9 Erwin Dokter 2011-12-15 14:13:02 UTC
Good idea.

Additionally, this problem holds for *all* external link declaration in Vector, Monobook, Modern and Simple skins. They will all need to be split, and preferably moved to common.
Comment 10 Gerrit Notification Bot 2013-09-15 17:42:02 UTC
Change 84228 had a related patch set uploaded by Bartosz Dziewoński:
Drop unnecessary CSS selectors for a.external[href^="gopher://"]

https://gerrit.wikimedia.org/r/84228
Comment 11 Gerrit Notification Bot 2013-09-15 19:42:47 UTC
Change 84228 merged by jenkins-bot:
Drop unnecessary CSS selectors for a.external[href^="gopher://"]

https://gerrit.wikimedia.org/r/84228
Comment 12 Bartosz Dziewoński 2013-09-15 19:45:19 UTC
The patch above should fix the issue by killing the selectors for gopher (which were pointless anyway, using the same styles as regular external links).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links