Last modified: 2011-10-15 22:03:17 UTC
When file name contains characters which are not permitted the upload form shows a warning message while in fact this is a blocking error.
Created attachment 9209 [details] Patch Changed the description from warning to error (string already existed). As far as I can tell, this method (showRecoverableUploadError) is never called by warnings, only by errors (MIN_LENGTH_PARTNAME, ILLEGAL_FILENAME, FILENAME_TOO_LONG, FILETYPE_MISSING, WINDOWS_NONASCII_FILENAME and verifyTitlePermissions). This is my first patch, please be gentle.
Any chance the patch could be attached in unified diff format ([[w:Diff#Unified_format]]). Thanks.
Created attachment 9218 [details] Unified diff? Like that?
Created attachment 9219 [details] patch, unified diff Better yet.
(In reply to comment #4) > Created attachment 9219 [details] > patch, unified diff > > Better yet. Yep, that's much better.
Created attachment 9227 [details] SVN diff, as Per Amir's request.
Patch applied in r99700 (what a nice number). Thank you.
tagging bugs for Marcus to look at