Last modified: 2012-02-24 02:52:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33524, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31524 - section links on file pages scroll too far down
section links on file pages scroll too far down
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-08 11:10 UTC by Sam Reed (reedy)
Modified: 2012-02-24 02:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments
Images! (111.72 KB, image/png)
2011-10-14 22:47 UTC, Sam Reed (reedy)
Details

Description Sam Reed (reedy) 2011-10-08 11:10:49 UTC
So you lose the title and the first line or so
Comment 1 Tomasz Finc 2011-10-14 00:27:26 UTC
Can you attach a screenshot. I'm not seeing this happen on a Nexus One or Droid Incredible
Comment 2 Sam Reed (reedy) 2011-10-14 15:57:23 UTC
Same for reflinks... Seems to scroll to the top of the window, not accounting for the search bar
Comment 3 Tomasz Finc 2011-10-14 16:39:22 UTC
So .. screenshot?
Comment 4 Sam Reed (reedy) 2011-10-14 19:03:25 UTC
Will do later, was done directly from my phone at the hola hotel. Phones not rooted, so need it attached to a computer to do a screenshot
Comment 5 Sam Reed (reedy) 2011-10-14 22:47:03 UTC
Created attachment 9235 [details]
Images!
Comment 6 Brion Vibber 2011-10-15 01:16:35 UTC
Ok, I think... we're actually ending up scrolling the parent document, not the iframe. The header is marked as position:fixed, which is why it doesn't scroll off screen with the rest of the document.

Not entirely sure if one-finger drag/scroll will work as expected if we make the main document fit the window and let the iframe scroll within itself.
Comment 7 Brion Vibber 2011-10-28 18:54:51 UTC
I tried swapping it to make the iframe limited size; seems to be glitchy in different ways on both Android 2.x and 3/4:

https://github.com/brion/Wikipedia/tree/scroll-adjust

notes on https://github.com/brion/Wikipedia/commit/e2d3b32b6b93e82c4e0a1b1b3ece018bc217a21c
Comment 8 Brion Vibber 2011-10-31 03:12:57 UTC
Tapping problem on Android 3 & 4 looks like http://code.google.com/p/android/issues/detail?id=20184
Comment 9 Brion Vibber 2011-12-23 19:18:51 UTC
My 'absolute' branch resolves this by removing the 'position: fixed' floating toolbar and letting it scroll off the page:
https://github.com/brion/Wikipedia/commits/absolute

It also provides more screen space for reading, which is a big plus in portrait orientation where a toolbar eats proportionately more screen space.
Comment 10 Phil Chang 2012-01-23 21:33:37 UTC
Is this resolved?
Comment 11 Sam Reed (reedy) 2012-01-23 21:55:11 UTC
Scrolling to references only work if you first expand the sections out (will log a bug fort hat)... But they do scroll to the correct place

Same for file pages

Guessing brions absolute branch fixed it

Marking it RESOLVED FIXED

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links