Last modified: 2011-10-28 02:38:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33550, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 31550 - Galleries in categories don't have newlines before/after page links.


Summary:	Galleries in categories don't have newlines before/after page links.

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	Categories (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	need-integration-test

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-10-09 03:38 UTC by Bawolff (Brian Wolff)
Modified:	2011-10-28 02:38 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot of lack of line break (190.68 KB, image/png) 2011-10-09 03:38 UTC, Bawolff (Brian Wolff)	Details
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2011-10-09 03:38:14 UTC

Created attachment 9195 [details]
Screenshot of lack of line break

Something to do with changing galleries from being a block element to weird <ul> inline-block thingy. Basically no linebreak before/after gallery so nav links on same line (noticable when only a few items). See screenshot


For reference, browser: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20110302 Iceweasel/3.5.16 (like Firefox/3.5.16) and trunk mediawiki (r99313)

Comment 1 Mark A. Hershberger 2011-10-15 22:03:10 UTC

tagging bugs for Marcus to look at

Comment 2 Derk-Jan Hartman 2011-10-22 21:28:04 UTC

Seems your browser is buying into the IE hack then....

	/* Galleries */
	/* These display attributes look nonsensical, but are needed to support IE and FF2 */
	/* Don't forget to update commonPrint.css */
	li.gallerybox {
		vertical-align: top;
		border: solid 2px white;
		display: -moz-inline-box;
		display: inline-block;
	}
	
	ul.gallery, li.gallerybox {
		zoom: 1;
		*display: inline;
	}
	
	ul.gallery {
		margin: 2px;
		padding: 2px;
		display: block;
	}

My chrome and safari ignore that display:inline; (as they should)....

Comment 3 Bawolff (Brian Wolff) 2011-10-23 18:46:42 UTC

Firebug is claiming that display style is set to inline-block...

It says the following styles are active o the li.gallerybox (minus a couple things inherited on pretty much all elements)

element.style {
 width:155px;
}
ul.gallery, li.gallerybox {
}
li.gallerybox {
 border:2px solid white;
 display:inline-block;
 vertical-align:top;
}
li {
 margin-bottom:0.1em;
}

Inherited from ul.gallery
ul {
 list-style-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAANCAMAAABW4lS6AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAFKM////QIUK9QAAAAJ0Uk5T/wDltzBKAAAAGklEQVR42mJgBAEGokgGBjBGBxBxsBqAAAMACHwALd5r8ygAAAAASUVORK5CYII=);
}
ul {
 line-height:1.5em;
 list-style-type:square;
}

Comment 4 Derk-Jan Hartman 2011-10-23 20:54:35 UTC

li.gallerybox is not relevant here right ? the ul.gallery is what should matter and which should behave like a block element.

Comment 5 Bawolff (Brian Wolff) 2011-10-23 21:25:08 UTC

(In reply to comment #4)
> li.gallerybox is not relevant here right ? the ul.gallery is what should matter
> and which should behave like a block element.

Whoops, yes you're right, ul.gallery is the important one.


Firebug says for the ul.gallery we have
ul.gallery {
display:inline-block;
margin:2px;
padding:2px;
}

Which is coming from mediawiki.legacy.shared. My shared.css looks different from what you pasted above (seems to have been changed in r93581)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links