Last modified: 2014-07-23 20:46:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33595, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31595 - CentralNotice banners should exist in their own namespace (stop using the MediaWiki namespace)
CentralNotice banners should exist in their own namespace (stop using the Med...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: fun-com, fundraising
: 42488 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-10 20:55 UTC by Arthur Richards
Modified: 2014-07-23 20:46 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Richards 2011-10-10 20:55:37 UTC

    
Comment 1 Arthur Richards 2011-12-06 20:27:19 UTC
This was mentioned to my Tim Starling a while back and I didn't add a description hoping he'd add it in his own words since I didn't have full details about what he was envisioning.
Comment 2 Adam Wight 2012-10-21 15:42:04 UTC
Confirmed.  The banner bodies are namespaced under "MediaWiki:Centralnotice-template-", and message fields are under "MediaWiki:Centralnotice-(templatename)-", but there could be collisions with builtin CN messages.

Not sure that will ever become a problem, it would take some very odd banner naming to cause a collision.
Comment 3 the wub 2012-11-28 10:54:47 UTC
*** Bug 42488 has been marked as a duplicate of this bug. ***
Comment 4 Liangent 2012-11-28 11:01:35 UTC
Hope that the new system can have a better fallback chain.
Comment 5 Dereckson 2012-11-28 16:45:32 UTC
Could you clarify the fallback chain issue Liangent?
Comment 6 Liangent 2012-11-28 16:50:22 UTC
(In reply to comment #5)
> Could you clarify the fallback chain issue Liangent?

Currently CN fetches message with wfMessage() which doesn't really go through the fallback chain (like zh-cn -> zh-hans -> zh -> en) when getting a message from database (instead it uses zh-cn -> en). This has been logged as a bug in i18n system but was never fixed. If CN turns to its own message fetching code it can avoid this issue of wfMessage().
Comment 7 Liangent 2012-11-28 16:52:05 UTC
(In reply to comment #5)
> Could you clarify the fallback chain issue Liangent?

Direct effect: stewards have to populate /zh-cn, /zh-hk, /zh-mo, /zh-my, /zh-sg, /zh-tw, /zh-hans, /zh-hant and /zh subpages (9 in total) instead of simple /zh-hans and /zh-hant (2 in total).
Comment 8 Liangent 2012-11-28 16:54:15 UTC
(In reply to comment #6)
> This has been logged as a bug in i18n system but was never fixed.

It's bug 1495. Sorry for spamming with comments.
Comment 9 Amgine 2012-11-28 16:56:16 UTC
Wouldn't it be better to fix the known bug in i18n than replicate functionality?
Comment 10 Liangent 2012-11-28 17:03:47 UTC
(In reply to comment #9)
> Wouldn't it be better to fix the known bug in i18n than replicate
> functionality?

First, fixing that issue is not the goal of this new-namespace design. It's just something "we should notice or remember" when implementing this new namespace. Second, that issue may be not so easy to fix (otherwise it shouldn't be living there for such a long time...) Anyway you're welcome to fix that bug. :)
Comment 11 MZMcBride 2012-11-28 22:06:35 UTC
Copying the stats from bug 42488 comment 0:
> The CentralNotice extension currently uses the MediaWiki namespace for storage.
> Today, Meta-Wiki has 53,320 pages in the MediaWiki namespace; of those, 51,147
> begin with "Centralnotice".
Comment 12 Matt Walker 2012-11-29 00:29:29 UTC
(In reply to comment #6)
> Currently CN fetches message with wfMessage() which doesn't really go through
> the fallback chain (like zh-cn -> zh-hans -> zh -> en) when getting a message
> from database (instead it uses zh-cn -> en).

Not that this really helps, but I have about five i18n patches for CentralNotice in a holding pattern until after the fundraiser. One of which addresses this exact issue. I looked at fixing the core i18n code and though doable it was a more significant investment of time than I wanted to expend at the time I wrote my patch. Seeing as I'm waiting till January to deploy this patch set anyways I can probably go and fix the bug in core.

-- As to moving things to their own namespace. With the deployment of the CN i18n stuff we will in fact have our own namespace but it will be as a scratch space for the translate extension. Once it's been marked as translated/approved we move it into MW again. I kept it this way for backwards compatibility reasons (mostly that I didn't want to have to write code to look in multiple locations for the banner.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links