Last modified: 2011-10-25 22:20:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33647, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31647 - Regression: __NOEDITSECTION__ is ignored when the page is read from the parser cache
Regression: __NOEDITSECTION__ is ignored when the page is read from the parse...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.20.x
All All
: Highest normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-12 16:12 UTC by Brad Jorsch
Modified: 2011-10-25 22:20 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to have ParserCache check for __NOEDITSECTION__ (724 bytes, patch)
2011-10-12 16:12 UTC, Brad Jorsch 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2011-10-12 16:12:02 UTC 
Created attachment 9222 [details]
Patch to have ParserCache check for __NOEDITSECTION__

After the fix for bug 31445, __NOEDITSECTION__ is now ignored when the page is loaded from the parser cache.

The problem seems to be that ParserCache's get() is not taking into account the possibility of __NOEDITSECTION__ when calling ParserOutput's setEditSectionTokens().

An easy patch is attached, although it may not be the best way to do it.
Comment 1 Platonides 2011-10-25 22:20:25 UTC 
I see. the parser, which is the entity knowing about __NOEDITSECTION__, is no longer run there, so it doesn't come to decide on it and the default (ie. without taking __NOEDITSECTION__ into account) is used. Still, I don't think that logic should be in ParserCache.

Should be fixed in r100756.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links