Last modified: 2012-07-29 19:39:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33722, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31722 - ugly old toolbar icons - height inconsistent
ugly old toolbar icons - height inconsistent
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-15 09:14 UTC by Eran Roz
Modified: 2012-07-29 19:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Eran Roz 2011-10-15 09:14:15 UTC 
Toolbar icons in the old toolbar are defined to be 23X23 (see here:
http://en.wikipedia.org/w/resources-1.18/resources/mediawiki.action/mediawiki.action.edit.js in insertButton)

but the images are 23X22, for example:
http://bits.wikimedia.org/skins-1.18/common/images/button_bold.png
http://bits.wikimedia.org/skins-1.18/common/images/button_link.png

And it is ugly!
Comment 1 Derk-Jan Hartman 2011-10-22 19:19:52 UTC 
Was indeed always 23x22
http://svn.mediawiki.org/viewvc/mediawiki/branches/REL1_16/phase3/skins/common/edit.js?view=markup

Was changed when merged to the mediawiki.action.edit.js

r1=80582&r2=83067">http://svn.mediawiki.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js?r1=80582&r2=83067
Comment 2 Derk-Jan Hartman 2011-10-22 19:22:41 UTC 
(In reply to comment #1)
> Was changed when merged to the mediawiki.action.edit.js

Copy paste mess, I meant r86603
Comment 3 Mark A. Hershberger 2011-10-28 15:36:54 UTC 
don't think ugly icons should block the tarball
Comment 4 Derk-Jan Hartman 2012-07-29 19:39:53 UTC 
This was fixed in r101990
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links