Last modified: 2011-11-19 11:58:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33851, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31851 - Block form URL parameters not working (wpBlockReason, wpBlockReasonList, etc.)
Block form URL parameters not working (wpBlockReason, wpBlockReasonList, etc.)
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-21 01:17 UTC by MZMcBride
Modified: 2011-11-19 11:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2011-10-21 01:17:30 UTC
It seems like &wpBlockReason= and &wpBlockReasonList= URL parameters are no longer working in MediaWiki 1.18 (whichever version is deployed to Wikimedia wikis right now). And possibly &wpBlockExpiry as well? r83795 seems like the likely culprit.

Sample URL: https://test.wikipedia.org/w/index.php?title=Special:Block&wpBlockAddress=Former+user+9172&wpBlockExpiry=indefinite&wpBlockReasonList=Abusing+%5B%5BWP%3ASock+puppetry|multiple+accounts%5D%5D&wpBlockReason=Please+see%3A+%5B%5BWikipedia%3ASockpuppet+investigations%2FFormer+user+9172%5D%5D
Comment 1 Antoine "hashar" Musso (WMF) 2011-11-01 10:16:35 UTC
Already reported. Also have a look at r101464

*** This bug has been marked as a duplicate of bug 30909 ***
Comment 2 Brad Jorsch 2011-11-01 16:34:01 UTC
Not a dup of that bug.

wpBlockReason, wpBlockReasonList, and wpBlockExpiry have been renamed to wpReason-other, wpReason, and wpExpiry, respectively. So https://test.wikipedia.org/w/index.php?title=Special:Block&wpBlockAddress=Former+user+9172&wpExpiry=indefinite&wpReason=Abusing+%5B%5BWP%3ASock+puppetry|multiple+accounts%5D%5D&wpReason-other=Please+see%3A+%5B%5BWikipedia%3ASockpuppet+investigations%2FFormer+user+9172%5D%5D should work for you.

I'll leave it to someone else to decide whether this should be WONTFIX or if compatibility logic should be added as is already done for wpBlockAddress.
Comment 3 MZMcBride 2011-11-01 23:12:52 UTC
This is a completely unnecessary breaking change to existing URLs. The pre-existing parameters should be re-added / re-implemented.
Comment 4 Antoine "hashar" Musso (WMF) 2011-11-10 12:59:15 UTC
That special page was migrated to use HTMLForm a modern way to handles form in MediaWiki.

The change of query parameters can cause trouble to people using some javascript to reuse the form. Those scripts should probably be use the API instead.

I am against added a layer of compatibility but maybe we can thrown a warning message when the old parameters are used.

My advice is to migrate to the API calls.
Comment 5 Brad Jorsch 2011-11-10 18:18:07 UTC
(In reply to comment #4)
> The change of query parameters can cause trouble to people using some
> javascript to reuse the form. Those scripts should probably be use the API
> instead.

It also causes problems for things like enwiki's [[Template:Emergency-bot-shutoff]]. The API can't really be used there. OTOH, it's also easy to fix a template like that.
Comment 6 MZMcBride 2011-11-11 06:04:57 UTC
I don't see any reason the parameters were renamed or removed (I'm not really sure which is the case here, I just know they're broken). Unless there was a valid reason to break the existing parameters, they should continue to work.
Comment 7 Mark A. Hershberger 2011-11-17 19:29:33 UTC
(In reply to comment #4)
> My advice is to migrate to the API calls.

Moving to low priority as a result.
Comment 8 Antoine "hashar" Musso (WMF) 2011-11-19 11:58:06 UTC
The main reason for the change was to remove the 'Block' part in variable name which does not make that much sense with the new HTMLForm.

This bug report is a valid one but not going to fix or add a compatibility layer. Most templates have been updated for now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links