Last modified: 2011-11-03 00:19:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33870, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31870 - The check mark image and the cross mark image no longer appear
The check mark image and the cross mark image no longer appear
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-22 00:17 UTC by Salem
Modified: 2011-11-03 00:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Salem 2011-10-22 00:17:55 UTC 
The check mark image and the cross mark image no longer appear when "Check syntax", "Test" and "Test filter" buttons are hit.

Image of check mark: http://commons.wikimedia.org/wiki/File:Yes_check.svg
Image of the cross mark http://en.wikipedia.org/wiki/File:X_mark.svg
Comment 1 Brion Vibber 2011-11-03 00:09:43 UTC 
I'm removing needs-regression-test as it's not super easy to make a test for that right now.


Main problem was r81905, which consolidated separate 'border-repeat' and 'border-position' specifications into a single 'border' rule. This unfortunately creates an implied 'background-image: none', which overrides the background-image: url(yes_check.png) etc.

Undoing that seems to help.

Additionally on trunk, the files didn't get moved along with the CSS so can't be found.
Comment 2 Brion Vibber 2011-11-03 00:13:52 UTC 
Fixed on trunk in r101756. Needs a slightly different patch for 1.18 (pre resourceloaderification of the ext)
Comment 3 Brion Vibber 2011-11-03 00:19:16 UTC 
Fixed on REL1_18 in r101758. Marking for merge to 1.18wmf1 for upcoming deployment.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links