Last modified: 2011-11-04 01:34:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33878, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31878 - Api should not clobber xml namespaces when already in use
Api should not clobber xml namespaces when already in use
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-22 05:09 UTC by Daniel Friesen
Modified: 2011-11-04 01:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Friesen 2011-10-22 05:09:34 UTC
Split off from bug 31542.

The bug where the api clobbered the rsd xmlns with it's own api ns was 'fixed' when it was changed so that the xml ns is only defined when includexmlnamespace is used. However that means the use of includexmlnamespace should still end up clobbering existing xmlns when it should not.

Hence, this bug... ;) open until we tweak the api code so that xmlns will not be overridden by the api's xmlns if an xmlns is already defined.
Comment 1 Brion Vibber 2011-11-03 23:16:37 UTC
Fixed on trunk in r101912.

This puts the namespace back unconditionally, *but* swaps the order of array combination so that any existing default xmlns gets kept.
Comment 2 Brion Vibber 2011-11-04 01:34:39 UTC
r101944 reverts most of r101912 except for the actual clobbering logic tweak -- apparently we needed to disable the namespaces by default anyway due to existing wild use of namespace-aware XML parsers (which thus would no longer recognize the "same" elements with a namespace without updating).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links