Last modified: 2011-10-24 23:46:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33920, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31920 - Resource Loader broken in HTML5 mode because type="text/javascript" is missing
Resource Loader broken in HTML5 mode because type="text/javascript" is missing
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.20.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-24 14:49 UTC by TMg
Modified: 2011-10-24 23:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description TMg 2011-10-24 14:49:13 UTC
In Html.php there are multiple places where the attribute type="text/javascript" is skipped or removed in HTML5 output mode.

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Html.php?view=markup

According to the HTML5 spec this is allowed.

Now I found a case where it's important to always have the type attribute. In the Opera web browser with the "NoAds" Opera extension installed and active all script without the type attribute are blocked.

Now you tell me "this is a problem of the extension then, not a problem of MediaWiki". I do not agree. It's impossible to tell if this extension is the only one with this particular problem. Fixing the extension would solve the problem for this extension only, leaving an unknown number of extensions and other tools and scripts broken.

Instead of starting a discussion about this I suggest to simply add the type attribute. It's not wrong or forbidden according to the spec. It's valid HTML5. It's more compatible with this attribute. The one and only downside is: it adds a few bytes. That's all from what I know. A few bytes for better compatibility.

Previous discussion about this topic:
http://www.mediawiki.org/wiki/Thread:Project:Current_issues/All_JavaScript_broken_in_Opera_due_to_jQuery_not_loaded%3F

Could be related to Bug #25179 and several other bugs relates to the Resource Loader but I'm not sure since there is to less information.
Comment 1 TMg 2011-10-24 23:44:43 UTC
I'm sorry. I was sure I found the reason but adding type="text/javascript" does not help.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links