Last modified: 2013-03-13 11:24:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33937, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 31937 - Allow groups to inherit permissions


Summary:	Allow groups to inherit permissions

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	need-unittest, patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-10-25 12:56 UTC by John Kettovsky
Modified:	2013-03-13 11:24 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch (4.58 KB, patch) 2011-11-20 13:46 UTC, cryptocoryne	Details
Add an attachment (proposed patch, testcase, etc.)

Description John Kettovsky 2011-10-25 12:56:27 UTC

Add wg variable to inherit group permissions, i. e. follow code:

$wgInheritGroupPermissions['sysop'] = array('editor');

And in Special:ListGroupRights MediaWiki displays simple "Inherit user rights of groups: Editors" instead of duplicate rights of "editor" group.

Comment 1 cryptocoryne 2011-11-20 13:46:59 UTC

Created attachment 9502 [details]
patch

Added a patch.

Comment 2 Sam Reed (reedy) 2012-01-16 15:52:53 UTC

This is something that could ideally do with some unittests. Would you be able to write some for this cryptocoryne?

And I don't think it should be committed before 1.19 is branched, as it has the potential to have numerous unwanted side effects

Comment 3 Sam Reed (reedy) 2012-01-16 15:54:09 UTC

Oh, also!

'listgrouprights-inherited' needs to be added to messages.inc and it'd be nice to have qqq documentation for it also

A quick browse over the patch suggests it's reasonably sane

Comment 4 Max Semenik 2012-02-28 15:07:05 UTC

-patch, -needs-review: reviewed by Sam, I concur with his analysis.

Comment 5 Andre Klapper 2013-03-13 11:24:44 UTC

John: Would you be able to write unittests?
Also, you are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit an updated patch as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links