Last modified: 2012-11-11 15:21:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33961, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31961 - ResourceLoader should support lang=qqx parameter
ResourceLoader should support lang=qqx parameter
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Low minor (vote)
: Future release
Assigned To: Nobody - You can work on this!
:
: 38731 39028 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-26 16:43 UTC by Liangent
Modified: 2012-11-11 15:21 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2011-10-26 16:43:39 UTC
http://en.wikipedia.org/wiki/0.999...?uselang=qqx

The "Rate this page" panel doesn't get message-names-as-contents replacement.
Comment 1 Niklas Laxström 2011-10-26 16:48:43 UTC
Slippery slope. It takes more and more effort to get it work everywhere for diminishing returns.
Comment 2 Brion Vibber 2011-10-26 21:19:14 UTC
Why wouldn't this just work automatically? Is ResourceLoader fetching messages in a different way from other things, such that the LanguageQqx::getMessage() never gets called?
Comment 3 Niklas Laxström 2011-10-27 06:04:04 UTC
I think uselang is not passed forward to resource loader.
Comment 4 Liangent 2011-10-27 11:35:34 UTC
(In reply to comment #3)
> I think uselang is not passed forward to resource loader.

See the panel on http://en.wikipedia.org/wiki/0.999...?uselang=de
Comment 5 Brion Vibber 2011-11-03 22:45:11 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I think uselang is not passed forward to resource loader.
> 
> See the panel on http://en.wikipedia.org/wiki/0.999...?uselang=de

Are you confirming that the uselang language *is* passed through to ResourceLoader? (It'd be insane if it wasn't; I wouldn't even know how it could *not* get passed...)
Comment 6 Liangent 2011-11-04 03:00:30 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > I think uselang is not passed forward to resource loader.
> > 
> > See the panel on http://en.wikipedia.org/wiki/0.999...?uselang=de
> 
> Are you confirming that the uselang language *is* passed through to
> ResourceLoader? (It'd be insane if it wasn't; I wouldn't even know how it could
> *not* get passed...)

http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=de&modules=ext.articleFeedback.ratingi18n&skin=vector&version=20111103T224533Z&*

http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=qqx&modules=ext.articleFeedback.ratingi18n&skin=vector&version=20111103T224533Z&*
Comment 7 Nemo 2012-07-28 16:53:15 UTC
AFT still ignores qqx, see https://en.wikipedia.org/wiki/Golden-crowned_Sparrow?uselang=qqx (you need to log out).
https://en.wikipedia.org/wiki/Golden-crowned_Sparrow?uselang=it works.

(In reply to comment #1)
> Slippery slope. It takes more and more effort to get it work everywhere for
> diminishing returns.

Closing in analogy to bug 29733.
Comment 8 Nemo 2012-07-28 17:20:44 UTC
*** Bug 38731 has been marked as a duplicate of this bug. ***
Comment 9 Robin Pepermans (SPQRobin) 2012-07-29 16:47:24 UTC
Re-opening as lowest/trivial. Even though this is very low priority to fix, it *is* still a bug.
Comment 10 Robin Pepermans (SPQRobin) 2012-08-05 20:16:49 UTC
*** Bug 39028 has been marked as a duplicate of this bug. ***
Comment 11 Krinkle 2012-08-06 23:40:38 UTC
Moving to ResourceLoader component.

On en.wikipedia.org/?uselang=qqx you'll notice that the Search and Wikimedia
Shop link are also in English.

As Brion already thought, the problem is not in how uselang is passed to ResourceLoader, because the requests to it do contain the correct language code. When breaking it down to a basic request, here's what I get:

https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=true&modules=mediawiki.util&lang=qqx


> mw.loader.implement("mediawiki.util", ["//bits.wikimedia.org/static-1.20wmf8/resources/mediawiki/mediawiki.util.js"], {}, {"showtoc":"show","hidetoc":"hide"});

Looks like the issue may be in MessageBlobStore or something.
Comment 12 Bartosz Dziewoński 2012-11-11 15:17:04 UTC
This appears fixed now; I can't reproduce the original issue, nor the issue under the URL linked by Krinkle in comment 11.

I get: mw.loader.implement("mediawiki.util", ["//bits.wikimedia.org/static-1.21wmf3/resources/mediawiki/mediawiki.util.js"], {}, {"showtoc":"(showtoc)","hidetoc":"(hidetoc)"});
Comment 13 Nemo 2012-11-11 15:21:47 UTC
Same for me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links