Last modified: 2011-11-02 21:25:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33996, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31996 - CSS extension cleanup
CSS extension cleanup
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CSS (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-27 19:26 UTC by Rusty Burchfield
Modified: 2011-11-02 21:25 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed patch (3.09 KB, patch)
2011-10-27 19:26 UTC, Rusty Burchfield 		Details
Proposed patch (use FormatJson::encode) (3.10 KB, patch)
2011-10-27 22:34 UTC, Rusty Burchfield 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Rusty Burchfield 2011-10-27 19:26:00 UTC 
Created attachment 9301 [details]
Proposed patch

Updates / Fixes:
* Make CSS files relative to $wgScriptPath (for portability), override with $wgCSSPath (allows alternate domain as well)
* Allow caching (add CSS to <head> via inline JS)
* Only use "blue-link" titles in article case
* Use HTML::linkedStyle, etc. functions (improves security)
* Remove extra htmlspecialchars on inline CSS
Comment 1 John Du Hart 2011-10-27 22:23:37 UTC 
Thank you for the exceptionally well done patch. There's just one thing that needs to be changed.

Instead of using json_* functions directly we have a wrapper class called FormatJson. In case the json extension isn't available or suffers from a specific bug, a fallback parser is used.

So, just replace the json_encode call with FormatJson::enocde and it's ready to commit
Comment 2 Rusty Burchfield 2011-10-27 22:34:43 UTC 
Created attachment 9304 [details]
Proposed patch (use FormatJson::encode)
Comment 3 John Du Hart 2011-10-28 15:33:22 UTC 
r101141

Thanks again for the patch.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links