Last modified: 2012-04-18 02:33:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32009 - Application won't compile without commenting out 2 overrides
Application won't compile without commenting out 2 overrides
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: High normal
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-28 02:21 UTC by Sam Reed (reedy)
Modified: 2012-04-18 02:33 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-10-28 02:21:43 UTC
Description	Resource	Path	Location	Type
The method onClick(View) of type new View.OnClickListener(){} must override a superclass method	WikiItemizedOverlay.java	/Wikipedia/src/org/wikipedia	line 65	Java Problem
The method run() of type ToastPlugin.RunnableToast must override a superclass method	ToastPlugin.java	/Wikipedia/src/com/chariotsolutions/toast/plugin	line 48	Java Problem



Commenting out the "@Override" is enough to get rid of the errors, but does mean it wouldn't work out of the box for people..

Version: 3.7.1
Build id: M20110909-1335


on Win 7 x64 etc
Comment 1 Brion Vibber 2011-10-28 17:35:42 UTC
Works for me with Android SDK r14.
Comment 2 Brion Vibber 2011-10-28 17:53:23 UTC
Hm, I do see these errors in Eclipse, but the command-line build is fine for me. sigh
Comment 3 Sam Reed (reedy) 2011-10-28 17:54:27 UTC
(In reply to comment #2)
> Hm, I do see these errors in Eclipse, but the command-line build is fine for
> me. sigh

Well done Java!
Comment 4 Brion Vibber 2011-10-28 18:02:25 UTC
Looks like some versions of JDK 1.5 and/or 1.6 throw this complaint when @Override'ing things on an interface:

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5008260

On my Mac laptop, switching from JDK 1.5 to 1.6 in the project's Java settings clears it up.
Comment 5 Sam Reed (reedy) 2011-10-28 18:36:31 UTC
Confirmed.

Can we just push the project upto 1.6 by deault?
Comment 6 Phil Chang 2011-12-14 00:37:17 UTC
sounds like a good policy, can we close this?
Comment 7 Tomasz Finc 2011-12-15 00:05:22 UTC
Yup. Resolving.
Comment 8 Jon Davis 2012-04-15 08:42:58 UTC
Can I suggest someone tosses this into the README/FAQ?  I ran into this same issue when checking out the code for the first time on my Mac.
Comment 9 Tomasz Finc 2012-04-16 19:07:44 UTC
(In reply to comment #8)
> Can I suggest someone tosses this into the README/FAQ?  I ran into this same
> issue when checking out the code for the first time on my Mac.

I just checked out a fresh copy and didn't have to change any code to compile. Jon, what version of Xcode are you on?
Comment 10 Jon Davis 2012-04-18 02:33:50 UTC
I was doing this on Eclipse for Android (on OSX).


Eclipse - 3.7.2
Xcode - 4.3.2 (4E2002)
Android SDK - rev19
OSX - 10.7.3

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links