Last modified: 2014-09-24 01:21:27 UTC
Per Nikerabbit on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101079#c25074 "So if the table doesn't exist, the only output is "...foo doesn't exist.". That's quite weird and ambiguous I think." We should update the updater functions so full lines (sentences, even) are output, rather than full in some cases, half in others
Created attachment 9372 [details] improved updater output messages
Hello, i've changed the updater functions and now the Output looks like this: "Dropping table foo... foo doesn't exist, skipping drop table" i've also changed the dropfield,addTable,etc functions that the output full lines
David, thank you for the patch. I am asking developers to review it. Chad Horohoe said that he hasn't had time to write up a reply to you, but that we can't take your patch as it is right now, since doing it the way the patch proposes would undo another bugfix. I'm going to get someone to give you an actually *informative* review as soon as possible. Thanks again.
r103691 Thanks
change reverted by r103892 because of bug 32508 "too many update messages even though nothing happens"
Created attachment 14882 [details] improved updater output messages
Hi Rahul! Thanks for your patch! Patches must go to Gerrit instead of Bugzilla though. You are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
