Last modified: 2011-10-31 17:31:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34073, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32073 - update.php's "iknowwhatimdoing" parameter is poorly named
update.php's "iknowwhatimdoing" parameter is poorly named
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-31 05:45 UTC by MZMcBride
Modified: 2011-10-31 17:31 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2011-10-31 05:45:54 UTC
In r92109, a parameter to maintenance/update.php was added called "iknowwhatimdoing". It overrides the (now default) behavior of blocking the execution of update.php when $wgMiserMode is enabled, unless the parameter is called (e.g., "php maintenance/update.php --iknowwhatimdoing").

I understand that this was likely intended to be a playful parameter name, but given that this parameter is called in the context of serious and potentially dangerous database schema changes, I think this parameter should be renamed. I think something like --force or --force=true makes more sense here and would be more common terminology for a command-line script of this nature. It's also a shorter, simpler word, which is more helpful than a long string of characters for people whose primary language isn't English.

Combined with bug 32072, I think this will vastly improve r92109.
Comment 1 Aaron Schulz 2011-10-31 17:31:10 UTC
Renamed in r101370.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links