Last modified: 2011-12-01 20:25:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34075, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32075 - Always add lowercase interwikis
Always add lowercase interwikis
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Interwiki (extension) (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: X!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-31 13:55 UTC by Vitaliy Filippov
Modified: 2011-12-01 20:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
A patch to lowercase added prefixes (464 bytes, patch)
2011-10-31 13:55 UTC, Vitaliy Filippov 		Details
v2 (2.41 KB, patch)
2011-11-16 11:09 UTC, Vitaliy Filippov 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Vitaliy Filippov 2011-10-31 13:55:17 UTC 
Created attachment 9323 [details]
A patch to lowercase added prefixes

I think the extension should always add interwikis with lowercased prefixes, as MediaWiki code expects it to be lowercased, and there can be a case-sensitive collation in the database.
Comment 1 Daniel Friesen 2011-10-31 14:01:53 UTC 
Interwiki uses Language::lc, mb_strtolower should not be used directly.
Comment 2 Sumana Harihareswara 2011-11-12 13:32:41 UTC 
Vitaliy, thanks for the patch.  I'm marking it "reviewed" since Daniel gave you some suggestions; do you have time to revise it?  Thanks.
Comment 3 Vitaliy Filippov 2011-11-16 11:09:28 UTC 
Created attachment 9465 [details]
v2

It's so trivial there's almost nothing to revise...
Comment 4 Robin Pepermans (SPQRobin) 2011-12-01 20:25:27 UTC 
Done in r104892 (the patch contained other changes too, btw).

(Also, as far as I tested, interwiki prefixes with capital letters are ignored and just render as normal (red)links, so adding them should indeed be impossible. What confuses me is that they *do* work on translatewiki.net.)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links