Last modified: 2011-11-09 17:39:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34126, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32126 - [regression] Special:EditWatchlist won't save if checked titles aren't currently on watchlist
[regression] Special:EditWatchlist won't save if checked titles aren't curren...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Watchlist (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.18.0 release
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-01 20:03 UTC by LordAndrew
Modified: 2011-11-09 17:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description LordAndrew 2011-11-01 20:03:36 UTC
If you check items on Special:EditWatchlist in 1.18+ that are not on your watchlist, submitting will result in a "There are problems with some of your input" error, with "The value you specified is not a valid option." at the bottom of the offending section. As a result the watchlist will not save and the user has to submit the form again for it to work. This error would usually (always?) happen because the user clicked the link to page and unwatched it from there. Since the form is intended to remove pages from one's watchlist, it should not be considered an error if a page has already been removed. It should submit successfully, like it did in 1.17 and earlier.
Comment 1 Brion Vibber 2011-11-02 19:10:21 UTC
Seems to be a side-effect of switching it to use HTMLForm; the series of checkboxes are made with HTMLMultiSelect which appears to want to validate every input value.

This baffles me generally because MultiSelect would presumably be a <select> listbox with the multiple-selection option enabled. WTF?

I can see a way to add a validation callback to declare things invalid, but not one to declare things as valid.... except by returning a true-ish but !== true value, which looks fragile and may not be a safe interface to use.
Comment 2 Brion Vibber 2011-11-02 19:37:06 UTC
Fixed on trunk in r101666 -- marking for merge.
Comment 3 Antoine "hashar" Musso (WMF) 2011-11-09 17:39:00 UTC
Merged in 1.18 by r101666

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links