Last modified: 2011-11-02 15:19:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34134, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32134 - HistoryAction.php gives MySQL-warning when no matching revisions are found


Summary:	HistoryAction.php gives MySQL-warning when no matching revisions are found

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	History/Diffs (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	John Du Hart

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-01 23:58 UTC by MrBlueSky
Modified:	2011-11-02 15:19 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch against trunk (767 bytes, patch) 2011-11-01 23:58 UTC, MrBlueSky	Details
Add an attachment (proposed patch, testcase, etc.)

Description MrBlueSky 2011-11-01 23:58:55 UTC

Created attachment 9345 [details]
patch against trunk

For example: http://<some1.19.wiki>/w/index.php?title=Main_Page&action=history&tagfilter=abcd123

HistoryPager::doBatchLookups() doesn't check for an empty result set before calling ResultWrapper::seek(0).

Comment 1 John Du Hart 2011-11-02 15:19:26 UTC

Thank for very much for the patch and bug report. I've fixed this in r101629 using an alternate method. So instead of only checking if there are results before using seek, we can return from the function immediately as nothing will be accomplished with no results anyway.

Hope to see some more patches and reports from you soon :)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links