Last modified: 2012-08-03 19:52:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34178, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32178 - change preset of expiry field of Special:Block
change preset of expiry field of Special:Block
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.16.x
All All
: Unprioritized enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-03 16:51 UTC by Mike Linksvayer
Modified: 2012-08-03 19:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike Linksvayer 2011-11-03 16:51:12 UTC
With 'other' as default, blocking requires at least one click or typing to change field or enter other time. It would be nice if defaulted to last value used (I often block a bunch of users in succession) or if not available, the most generally applicable non-'other' choice (I'd vote for 'infinite' but don't care much).
Comment 1 Waldir 2012-03-31 12:01:20 UTC
I support this. I often perform maintenance in small wikis where spam is rampant, and blocking multiple users is cumbersome when one has to triple the clicks needed to get it done (one to reveal the dropdown list, the other to pick the duration, and the third to click the "block" button), compared to, say, deleting pages.
Comment 2 Waldir 2012-03-31 12:07:55 UTC
Is it possible to gather data on what's the most common block duration chosen? (I'm willing to bet it's not "other".)
Comment 3 p858snake 2012-03-31 12:12:54 UTC
We don't record that it is a "other" choice in the db (from memory). But yes, if we really wanted to, we could probably get someone to scan this data from the cluster (Might actually be possible from the TS).
Comment 4 Waldir 2012-06-06 20:07:43 UTC
patch submitted here: https://gerrit.wikimedia.org/r/#/c/10469/
Comment 5 Waldir 2012-06-20 01:34:41 UTC
On gerrit, Aaron Schulz commented "I don't like giving IPs a default block time of indefinite. These needs a bit more thought IMO."

I agree; I wasn't too keen on making the default indefinite either. What if we made it configurable through a system message, which would default to the same as [[MediaWiki:ipbother]]? This would retain current behavior, but make it configurable by administrators of the site :)
Comment 6 Waldir 2012-06-20 01:39:25 UTC
Sorry, ipbother is not the appropriate message for what I meant. It should be [[Mediawiki:htmlform-selectorother-other]].
Comment 7 Waldir 2012-07-10 23:41:32 UTC
Ok, since nobody commented, I went ahead and implemented this. The new system message is "ipb-default-expiry" and it's an empty string by default (otherwise it would fill in the custom value box). Thus the current behavior is preserved, but by editing [[MediaWiki:ipb-default-expiry]], admins can change the default block expiry, for example by setting it to "infinite".

The new patch is on Gerrit, on the same link mentioned in comment #4.
Comment 8 Waldir 2012-08-03 19:52:34 UTC
Marking as fixed as this was just merged into the master git branch as change-id Icb1edabd8bb3dd1020c023b27b1270b9d2735b06

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links