Last modified: 2014-09-08 22:20:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34184, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32184 - WikiEditor: Replace $.client.profile().name === 'msie' with feature detection
WikiEditor: Replace $.client.profile().name === 'msie' with feature detection
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-03 18:59 UTC by Brion Vibber
Modified: 2014-09-08 22:20 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-11-03 18:59:22 UTC
Sniffing is unpleasant, and the needed stuff may or may not be relevant on future versions of IE.
Comment 1 Brion Vibber 2011-11-03 19:24:11 UTC
(This seems to be mostly used in checking whether we need to save/restore the scroll & selection state. Since an IE-specific interface is being used there, it may make more sense to base the check on that.)
Comment 2 Brion Vibber 2011-11-03 19:31:07 UTC
Comment 1 belonged on bug 32185. :) The .test() is being used as a blacklist for known-broken versions if I'm reading correctly, so this can be lower-priority.

Not ideal, but allows newer versions to work.

Several things are blacklisted without a version number, which may or may not actually belong there forever:

			'blackberry': false,
			'ipod': false,
			'iphone': false
Comment 3 Quim Gil 2014-04-12 06:50:07 UTC
"Lowest", reflecting the lack of activity in more than two years and the apparent lack of current plans.
Comment 4 Derk-Jan Hartman 2014-05-10 08:24:14 UTC
The problem with getting away from this is that what don't really have the information anymore as to WHY this stuff is on the blacklist.

I have at least made the full false into something that is versioned, exposing the wikieditor functionality starting iOS6 in this changeset: https://gerrit.wikimedia.org/r/#/c/132603/

The other profile check, is for IE problems, and that has to do with DOM changes removing focus from focusable elements. I'm not sure if that bug still exists in more recent versions.
Comment 5 Alexander Jones 2014-09-07 10:30:14 UTC
IE11 does maintain the selection when a dialog is opened and closed, but IE11, Firefox 31, and Chromium 36 cannot make any use of that because the textbox is not focused after the dialog is closed. The scrollTop thing also seems to be a non-issue on IE11.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links