Last modified: 2011-11-03 20:18:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34185, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32185 - Replace $.client.test() user-agent sniffing with feature detection in WikiEditor
Replace $.client.test() user-agent sniffing with feature detection in WikiEditor
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-03 19:01 UTC by Brion Vibber
Modified: 2011-11-03 20:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2011-11-03 19:01:23 UTC 
User-agent sniffing tends to break on future browser versions or browsers you don't know about; should use feature detection instead.

Agent sniffing can be sometimes appropriate to blacklist particular things we know are bad, but should be much more limited and explicit.
Comment 1 Brion Vibber 2011-11-03 19:26:23 UTC 
(This seems to be mostly used in checking whether we need to save/restore the
scroll & selection state. Since an IE-specific interface is being used there,
it may make more sense to base the check on that.)
Comment 2 Trevor Parscal 2011-11-03 20:18:26 UTC 
This is being used for a variety of things, which can not be feature detected, including CSS layout issues.

Yes, feature detection is superior, but it's not always possible.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links