Last modified: 2012-03-09 15:39:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34244, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32244 - Phonegap app settings dialog: checkbox, dropdown should trigger when tapping anywhere in the list item
Phonegap app settings dialog: checkbox, dropdown should trigger when tapping ...
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Settings (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
: 32924 34906 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-07 19:43 UTC by Brion Vibber
Modified: 2012-03-09 15:39 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-11-07 19:43:54 UTC
The sample checkbox & language selector in the settings screen have been restyled to look more Android-native.

However, they only activate when you tap directly on the checkmark or drop-down triangle on the right; they should also activate when tapping anywhere in the list item box, such as on the text label.
Comment 1 Liangent 2011-12-09 18:21:59 UTC
*** Bug 32924 has been marked as a duplicate of this bug. ***
Comment 2 Liangent 2011-12-09 18:23:28 UTC
I guess there's a "normal" widgets for such view (because lots of apps look similar) but the Wikipedia app is not using it. Simply using it may resolve this and bug 32913.
Comment 3 Brion Vibber 2011-12-09 18:26:50 UTC
The app is built with PhoneGap -- where you basically do your app as HTML in a web view -- and the settings dialog right now is one of the HTML parts, not a native Android view.

We could switch it to native Android controls, but would similarly need to make native panels on other systems such as iOS if going that route.
Comment 4 Liangent 2011-12-09 18:41:52 UTC
(In reply to comment #2)
> I guess there's a "normal" widgets for such view (because lots of apps look
> similar) but the Wikipedia app is not using it. Simply using it may resolve
> this and bug 32913.

bug 32913 should be bug 32902.
Comment 5 Phil Chang 2011-12-19 21:35:12 UTC
Probably going native with menus is inevitable. If this takes too long to fix or re-implement a native, let's flag it and related bugs for release 1.1.
Comment 6 Yuvi Panda 2011-12-20 13:56:35 UTC
Gave it a shot in https://github.com/yuvipanda/WikipediaMobile/commit/eed838575834a10d567799f75f22ffd616c746ba

Doesn't quite work - I'm unable to programatically trigger the select widget into opening.
Comment 7 Yuvi Panda 2011-12-20 22:05:29 UTC
Discussion with brion happend. Looks like this isn't actually possible, without moving away from using <select>s.
Comment 8 Liangent 2012-01-26 05:40:19 UTC
Why WONTFIX? Just because it's difficult to fix?
Comment 9 Yuvi Panda 2012-03-04 21:29:41 UTC
*** Bug 34906 has been marked as a duplicate of this bug. ***
Comment 10 Yuvi Panda 2012-03-04 21:32:13 UTC
@Liangent: Yes - it seems to be not possible to trigger selects from javascript in Android. I'd be happy to be proven wrong.

Will try get it to work on iOS.
Comment 11 Yuvi Panda 2012-03-05 20:50:40 UTC
@Liangent: Apparently 'not possible', not just difficult to fix (without completely re-creating the select UI). Won't fix for 1.1
Comment 12 Yuvi Panda 2012-03-05 21:16:59 UTC
Will be fixed as part of http://www.mediawiki.org/wiki/Glaucus
Comment 13 Jon 2012-03-06 11:50:44 UTC
I wonder if this could be done by giving the select menu width 100% so that it picks up clicks on the label which it overlaps.
Comment 14 Yuvi Panda 2012-03-06 13:01:04 UTC
Jon's right, I was looking at from the wrong angle (JS). CSS seems to provide a workable solution. On it.
Comment 15 Yuvi Panda 2012-03-06 16:40:55 UTC
Major improvement in https://github.com/wikimedia/WikipediaMobile/pull/161
Comment 16 Yuvi Panda 2012-03-08 19:29:00 UTC
Fixed in df82cc2f8643ba1a85212a2f00ef0f842c9e8d10

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links