Last modified: 2012-04-16 14:22:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34246, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32246 - Weird behavior when clicking on the name or the thumbnail of the file
Weird behavior when clicking on the name or the thumbnail of the file
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-07 21:11 UTC by Nux
Modified: 2012-04-16 14:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nux 2011-11-07 21:11:47 UTC
After I've chosen files to be uploaded (or donated if you will) with UploadWizard I can click on any file to choose a different file. This is something I haven't seen before and feels not intuitive.

1. What I would expect after clicking on a name would be to change the name of the file being uploaded.
2. What I would expect after clicking on a thumbnail (which is not a thumbnail BTW and feels wrong too) would be to see the picture being uploaded (it works as expected later on).
3. Remove shouldn't simply remove the file.

Note that I don't want push "upload" until the names are OK. If it is problematic then you should add a note that files are not uploaded yet and I can change their names later.

Also if you cannot display thumbnails I think you should show blank thumbnails but rather only show names of files.
Comment 1 Neil Kandalgaonkar 2011-11-07 22:50:18 UTC
If you click on the thumbnail you should get a zoomed-in version of the file. Are you sure that's what happens? If so, what browser and OS are you using?

Otherwise, this is known behavior -- I was sure there was a bug for this but now I can't find it. I agree that it's probably not good, but it's less urgent. You can still cancel if you want.

I agree we should fix it so you can alter the filename instead.


(In reply to comment #0)
> After I've chosen files to be uploaded (or donated if you will) with
> UploadWizard I can click on any file to choose a different file. This is
> something I haven't seen before and feels not intuitive.
> 
> 1. What I would expect after clicking on a name would be to change the name of
> the file being uploaded.
> 2. What I would expect after clicking on a thumbnail (which is not a thumbnail
> BTW and feels wrong too) would be to see the picture being uploaded (it works
> as expected later on).
> 3. Remove shouldn't simply remove the file.
> 
> Note that I don't want push "upload" until the names are OK. If it is
> problematic then you should add a note that files are not uploaded yet and I
> can change their names later.
> 
> Also if you cannot display thumbnails I think you should show blank thumbnails
> but rather only show names of files.
Comment 2 Nux 2011-11-08 08:18:59 UTC
Hm... Yes, so if the thumbnail thing is not intentional then this is probably related to Bug 26072. I would still expect a different behavior when clicking on a name or at least you could a a tooltip (title) to explain what happens when you click on a name.

My setup:
Opera version: 11.52
Compilation: 1100
Platform: Win32
System: Windows 7
Opera/9.80 (Windows NT 6.1; U; pl) Presto/2.9.168 Version/11.52
Comment 3 Mark A. Hershberger 2011-11-17 17:54:34 UTC
Clicking on the name opens a file upload dialog, but although changing the file to upload does change the text displayed (Instead of "File1.jpg" I now see "File2.jpg") the thumbnail does not change.
Comment 4 drecodeam 2012-04-14 17:29:38 UTC
Clicking on the name activates the hidden input element, and hence opens the upload file dialog. I have added a patch to fix this bug : https://gerrit.wikimedia.org/r/#change,4778.
Comment 5 Mark A. Hershberger 2012-04-16 14:02:59 UTC
Thanks for the patch... Tested and works.  Now, hopefully someone will apply it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links