Last modified: 2011-11-10 18:06:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34300, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32300 - LocalFile::getFileKey() undefined method while uploading
LocalFile::getFileKey() undefined method while uploading
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-09 00:02 UTC by Neil Kandalgaonkar
Modified: 2011-11-10 18:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
log files with live hack to show params from failing requests (14.77 KB, text/plain)
2011-11-09 19:28 UTC, Neil Kandalgaonkar
Details

Description Neil Kandalgaonkar 2011-11-09 00:02:49 UTC
Some combination of parameters causes this error in production:

    Call to undefined method LocalFile::getFileKey() in /usr/local/apache/common-local/php-1.18/includes/api/ApiUpload.php on line 155

Aaron Schulz investigated the backtrace in production, and it goes something like this:

PHP Notice:  Upload stash bug:
    * UploadFromStash.php line 105 calls wfBacktrace()
    * ApiUpload.php line 150 calls UploadFromStash->stashFile()
    * ApiUpload.php line 174 calls ApiUpload->performStash()
    * ApiUpload.php line 97 calls ApiUpload->dieRecoverableError()
    * ApiMain.php line 692 calls ApiUpload->execute()
    * ApiMain.php line 358 calls ApiMain->executeAction()
    * ApiMain.php line 342 calls ApiMain->executeActionWithErrorHandling()

Not sure exactly what the params are but it's as if we have parameters corresponding to a regular upload (like 'file') *and* an UploadFromStash ('filekey'). But that's supposed to be impossible, given the API restrictions.
Comment 1 Neil Kandalgaonkar 2011-11-09 00:32:31 UTC
We added some more debug stuff as a live hack -- just waiting for the error to trigger
Comment 2 Neil Kandalgaonkar 2011-11-09 19:28:24 UTC
Created attachment 9403 [details]
log files with live hack to show params from failing requests

We did a live hack to print out the params associated with these failing requests. Log attached.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links