Last modified: 2013-04-22 16:15:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34328, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32328 - On iOS 5 and earlier, UploadWizard should indicate it doesn't work
On iOS 5 and earlier, UploadWizard should indicate it doesn't work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-09 20:08 UTC by Neil Kandalgaonkar
Modified: 2013-04-22 16:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-11-09 20:08:30 UTC
On platforms like the iPad, clicking the "add an upload" button does nothing.
Comment 1 Neil Kandalgaonkar 2011-11-09 20:18:56 UTC
Actually, there is no way to use a standard file upload control on iOS, period, without installing some 3rd-party software.

UploadWizard does have a problem here, in that it's not obvious it won't work. Normally, on iOS, file upload fields are greyed out.
Comment 2 Brion Vibber 2011-11-10 20:55:00 UTC
It may be possible to detect that the <input type="file"> is disabled, in which case we can "gracefully enhance" if Apple gets their act together in iOS 6. :)
Comment 3 Brion Vibber 2011-11-10 21:04:19 UTC
Confirmed that the 'disabled' attribute gets set automatically on an <input type="file"> in Safari on iOS 4.3 and 5.0 (tested in simulator).

You can test in isolation by creating an input element dynamically:

	if ($('<input type="file">').attr('disabled')) {
		$('#info2').text('file upload is disabled');
	} else {
		$('#info2').text('enabled!');
	}
Comment 4 Mark Holmquist 2012-05-22 17:41:22 UTC
Marking as easy, it should be possible to fix this by adding in a simple, proper i18n message to let the user know that the feature isn't supported, and displaying it conditionally on page load. See Brion's comment for some help on how to detect whether the feature is missing.
Comment 5 Brion Vibber 2012-08-10 23:51:06 UTC
Note that file uploads are available on iOS 6, and so UploadWizard *should* work there...

Testing on the current beta, things partially work -- after selecting an image I end up with a thumbnail and all -- then I get "Unknown error: unknown-warning" during the upload stage.

Selecting a second image similarly partially works/partially fails, then pops up a dialog warning that "You are already uploading the file "image.jpg"." (apparently every file gets named as image.jpg during uploading...)
Comment 6 Brion Vibber 2012-08-10 23:55:39 UTC
Split iOS 6 issue out to bug 39256; adjusting summary to clarify this should apply to iOS 5 and earlier.
Comment 7 Derk-Jan Hartman 2012-09-13 21:38:31 UTC
https://gerrit.wikimedia.org/r/23763
Comment 8 Brion Vibber 2012-09-13 21:50:29 UTC
Tested and merged. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links